-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CHIPConfig.h not including InetConfig.h. #29223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had various things that were testing config bits that InetConfig.h would pull in that never actually included InetConfig.h, because CHIPConfig.h did not include it.
PR #29223: Size comparison from af635a6 to 80ff286 Increases above 0.2%:
Increases (7 builds for bl702, bl702l, cc13x4_26x4, cc32xx)
Decreases (2 builds for bl702)
Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
pidarped
approved these changes
Sep 13, 2023
PR #29223: Size comparison from af635a6 to 40255ba Increases above 0.2%:
Increases (1 build for cc32xx)
Full report (7 builds for cc32xx, k32w, mbed, qpg)
|
40255ba
to
4c960a8
Compare
PR #29223: Size comparison from 1d6ba7f to 4c960a8 Decreases (12 builds for bl702, bl702l, cc32xx, efr32, psoc6, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
approved these changes
Sep 13, 2023
andy31415
approved these changes
Sep 14, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Fix CHIPConfig.h not including InetConfig.h. We had various things that were testing config bits that InetConfig.h would pull in that never actually included InetConfig.h, because CHIPConfig.h did not include it. * Stop including inet things from CHIPCore.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had various things that were testing config bits that InetConfig.h would pull in that never actually included InetConfig.h, because CHIPConfig.h did not include it.