Make ReadClient::Callback non-movable #29191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspang
force-pushed
the
for-chip/non-movable
branch
from
cf60cb8
to
9e333f4
Compare
The purpose of this interface is be called polymorphically through a pointer. Moving it will invalidate the original instance and is very likely to be a bug. Make this type non-movable; this will fail compilation if a derived class is stored in an inappropriate container that moves its elements. As an example, ClusterStateCache is also currently movable, but moving it retains a pointer to the moved-from instance via mBufferedReader, so any further usage is likely to result in a invalid memory access.
mspang
force-pushed
the
for-chip/non-movable
branch
from
9e333f4
to
fcb4f0b
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #29191: Size comparison from 4442906 to fcb4f0b Increases (7 builds for bl702, cc32xx, psoc6)
Decreases (17 builds for bl702, bl702l, cc32xx, efr32, linux, psoc6)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 12, 2023
cecille
approved these changes
Sep 12, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
The purpose of this interface is be called polymorphically through a pointer. Moving it will invalidate the original instance and is very likely to be a bug. Make this type non-movable; this will fail compilation if a derived class is stored in an inappropriate container that moves its elements. As an example, ClusterStateCache is also currently movable, but moving it retains a pointer to the moved-from instance via mBufferedReader, so any further usage is likely to result in a invalid memory access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this interface is be called polymorphically through a pointer. Moving it will invalidate the original instance and is very likely to be a bug.
Make this type non-movable; this will fail compilation if a derived class is stored in an inappropriate container that moves its elements.
As an example, ClusterStateCache is also currently movable, but moving it retains a pointer to the moved-from instance via mBufferedReader, so any further usage is likely to result in a invalid memory access.