-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix JNI local reference leak for ChipAttributePath and ChipEventPath #29175
Merged
mergify
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_path_leak
Sep 13, 2023
Merged
[Android] Fix JNI local reference leak for ChipAttributePath and ChipEventPath #29175
mergify
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/fix_path_leak
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7084432
to
6064979
Compare
PR #29175: Size comparison from 8d0761d to 9309458 Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
9309458
to
5235da5
Compare
PR #29175: Size comparison from aed2bcd to 5235da5 Decreases (1 build for efr32)
Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
5235da5
to
4e0e41b
Compare
PR #29175: Size comparison from aed2bcd to 4e0e41b Increases (1 build for telink)
Decreases (1 build for efr32)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
Sep 13, 2023
saurabhst
approved these changes
Sep 13, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallStaticObjectMethod returns a local reference to whatever it is you're creating. Unless you return back to java or detach the native thread from the VM, that reference table isn't going to be cleared. We need explicitly clear them out. In order to fix this issue, we introduce RAII for ChipAttributePath and ChipEventPath in android JNI layer
#29069