-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change chip-tool to put its platform KVS in its storage directory. #29133
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-kvs-separate
Sep 13, 2023
Merged
Change chip-tool to put its platform KVS in its storage directory. #29133
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-kvs-separate
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02e4741
to
c38a457
Compare
PR #29133: Size comparison from 5ae3c65 to c38a457 Increases (2 builds for linux)
Decreases (3 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
c38a457
to
c226a76
Compare
PR #29133: Size comparison from 5ae3c65 to c226a76 Increases (1 build for linux)
Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
c226a76
to
563a844
Compare
PR #29133: Size comparison from 5ae3c65 to 563a844 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (2 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
And also name it chip_tool_kvs, not chip_kvs. This should avoid chip-tool stomping on the KVS of server-side apps.
563a844
to
45556c3
Compare
PR #29133: Size comparison from 5ae3c65 to 45556c3 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (2 builds for efr32, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Sep 12, 2023
jmartinez-silabs
approved these changes
Sep 13, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…roject-chip#29133) And also name it chip_tool_kvs, not chip_kvs. This should avoid chip-tool stomping on the KVS of server-side apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also name it chip_tool_kvs, not chip_kvs. This should avoid chip-tool stomping on the KVS of server-side apps.