Fix signatures of string-attribute getters in Accessors.h/cpp (1.1 backport of #29024) #29029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old signature did not propagate the update length of the span to the caller. This is a manual backport of project-chip#29024. The ZAP update is needed to get the right output. This modifies a few things, which were included in the PR so that the ZAP job would pass. The Darwin bits might not compile in this state, but that's OK.
tcarmelveilleux
approved these changes
Sep 2, 2023
bzbarsky-apple
deleted the
cherrypick-1ed389725756a7a5e6ce4c2e79e6458c7d89d2f6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old signature did not propagate the update length of the span to the caller.
This is a manual backport of #29024.
The ZAP update is needed to get the right output.
This modifies a few things, which were included in the PR so that the ZAP job would pass.
The Darwin bits might not compile in this state, but that's OK.