-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change waitForReport to manual in TC-SMOKECO #29009
Change waitForReport to manual in TC-SMOKECO #29009
Conversation
PR #29009: Size comparison from ea3970a to bbc7dba Increases (1 build for telink)
Decreases (2 builds for efr32, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@ericzijian1994 So is this working around #28257 not being merged? |
Yes...Recently, I saw https://github.com/CHIP-Specifications/chip-certification-tool/issues/951 , So I think if we don't have it solved at TH.. this PR can be a working around for the 1.2 SVE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please make sure a revert is tracked in an issue and the dependency on the issue that would allow the revert is marked in it.
Fast-tracking test-only change. |
Issue filed for tracking purpose #29065 |
* Change waitForReport to manual in TC-SMOKECO * Restyled by prettier-yaml --------- Co-authored-by: Hare <renilr0@outlook.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Change waitForReport to manual in TC-SMOKECO * Restyled by prettier-yaml --------- Co-authored-by: Hare <renilr0@outlook.com> Co-authored-by: Restyled.io <commits@restyled.io>
Situation
In TH tests, TC-SMOKECO may fail at the waitForReport step.
The problem
Because TH tests are slow, events are received before the waitForReport step.
This PR change is targeted to
This is a PR backup that changes most of the waitForReport to a manual operation.