Make AddStatus generally VerifyOrDie and have centralized logging #28634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
yunhanw-google
approved these changes
Aug 10, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
PR #28634: Size comparison from 7353fd6 to bdb900f Increases (23 builds for bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 10, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 11, 2023
…ging (project-chip#28634)" This reverts commit a98bc64.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Aug 11, 2023
…ging (project-chip#28634)" This reverts commit a98bc64. The revert is happening because of OpenIOT SDK perma-fail after that PR merged.
|
Note: this is being reverted in #28661 due to the OpenIOT perma-fail after this PR merged. Which is odd, because that job passed in the PR itself, but it's consistently failing everywhere after the merge. |
woody-apple
pushed a commit
that referenced
this pull request
Aug 11, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…oject-chip#28634) * Define a CommandStatus wrapper to handle logging * Add required methods in CommandHandler to use the new path logic * Convert a bunch of calls to AddStatus * Fix test compilation * Fix addresponse * Fix unit tests * Restyle * Try to reduce flash usage by not duplicating no context strings * Restyle * Code review comments * More code review fixes * code review update: addstatus in door lock has no error checking * Move inline function away - attempt to have less code size changes * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
…oject-chip#28634) * Define a CommandStatus wrapper to handle logging * Add required methods in CommandHandler to use the new path logic * Convert a bunch of calls to AddStatus * Fix test compilation * Fix addresponse * Fix unit tests * Restyle * Try to reduce flash usage by not duplicating no context strings * Restyle * Code review comments * More code review fixes * code review update: addstatus in door lock has no error checking * Move inline function away - attempt to have less code size changes * Restyle --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FailableAddStatuswhen we think we can handle or forward the underlying CHIP_ERRORFixes #28630