-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Fix crash on 32bit Android phone when eventing is enabled #28534
Merged
yufengwangca
merged 4 commits into
project-chip:master
from
yufengwangca:pr/java/crash_32bit
Aug 4, 2023
Merged
[Java] Fix crash on 32bit Android phone when eventing is enabled #28534
yufengwangca
merged 4 commits into
project-chip:master
from
yufengwangca:pr/java/crash_32bit
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Aug 4, 2023
PR #28534: Size comparison from a70d5b4 to 3a150e3 Increases (10 builds for bl702, cc32xx, cyw30739, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, bl702l, cyw30739, efr32, esp32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…ject-chip#28534) * [Java] Fix crash on 32bit Android phone when eventing is enabled * Restyled by clang-format * Address review comment * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the issue is that the wrong data type was used to pass the priorityLevel parameter to the JNI call.
which lead to incorrect interpretation of the value when passed to the JNI call on 32bit platform