Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when an error happens during a BLE scan on darwin. #28505

Merged
merged 1 commit into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. Fix crash when an error happens during a BLE scan on darwin.

    If we happened to do a BLE scan after doing a BLE connect, and then during the
    BLE scan one of two things happens:
    
    1. Bluetooth is shut down (e.g. by just turning it off via the menubar).
    2. The scan is a delegate-less scan and times out.
    
    then we would try to use the error handler that expects a SetUpCodePairer but
    without an actual non-null SetUpCodePairer to pass it.  And then that would
    crash.
    
    The fix is to not call an error handler that we're not supposed to be calling;
    scans do not call the _connection_ error handler.
    bzbarsky-apple committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d8869e4 View commit details
    Browse the repository at this point in the history