Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReadHandler] Removal of test flags #28421

Merged
merged 6 commits into from
Aug 3, 2023
Merged

[ReadHandler] Removal of test flags #28421

merged 6 commits into from
Aug 3, 2023

Commits on Aug 1, 2023

  1. Removed reportScheduler test flags and made TestReadInteractin.cpp wa… 

    …it for min/max instead of setting flags. Modified subscription times in the test to minimise the impact of waiting.
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d00fdce View commit details
    Browse the repository at this point in the history

  2. Restyled by clang-format

    @restyled-commits @lpbeliveau-silabs
    restyled-commits authored and lpbeliveau-silabs committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c7fb1d1 View commit details
    Browse the repository at this point in the history

  3. Added a driveAndServiceIO after waiting for max in test where we shou… 

    …ld wait for max to expire to ensure the run gets scheduled reliably
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1f56ddb View commit details
    Browse the repository at this point in the history

  4. Moved ctx.GetIOContext().DriveIO(); after each tests to garantee this… 

    … will run after maxInterval is expired
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    146cc01 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Implemented a mock clock in TestReadInteraction to reduce wait loops

    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5c605c3 View commit details
    Browse the repository at this point in the history

  2. Removed more loops and added comment on loop left in the code

    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    e7fe784 View commit details
    Browse the repository at this point in the history