Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICD] Add default ICD Behavior to readhandler when establishing a subscription #28375

Merged
merged 10 commits into from
Aug 1, 2023
Merged

[ICD] Add default ICD Behavior to readhandler when establishing a subscription #28375

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e06a57
add default ICD behavior to readhandler
mkardous-silabs Jul 28, 2023
19191c0
Add comments
mkardous-silabs Jul 28, 2023
8d52182
Update src/app/ReadHandler.cpp
mkardous-silabs Jul 28, 2023
a6a06e7
move check to top
mkardous-silabs Jul 31, 2023
07ae751
Add ICD unit tests for ReadHandler
mkardous-silabs Aug 1, 2023
02366b1
check to avoid division by 0
mkardous-silabs Aug 1, 2023
7b4ca59
fix dependency chain
mkardous-silabs Aug 1, 2023
672649a
restyle
mkardous-silabs Aug 1, 2023
97119f0
remove deps for manager srcs
mkardous-silabs Aug 1, 2023
b5ff2df
update IcdMangementServer test to reflect default idle mode value
mkardous-silabs Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix dependency chain
  • Loading branch information
@mkardous-silabs
mkardous-silabs committed Aug 1, 2023
commit 7b4ca5989ebc6d7534a005e2d6f729b8519c788b
7 changes: 5 additions & 2 deletions src/app/icd/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,13 @@ source_set("manager-srcs") {
]

deps = [
":cluster-srcs",
":observer-srcs",
]
public_deps = [ "${chip_root}/src/credentials:credentials" ]

public_deps = [
":cluster-srcs",
"${chip_root}/src/credentials:credentials",
]
}

# ICD management cluster source-set is broken out of the main source-set to enable unit tests
Expand Down