Move from .CODEOWNERS back to pull approve, and support optional reviewers #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
as code owners
saurabhst
approved these changes
Sep 25, 2020
| /.gn/ @chrisdecenzo @woody-apple @bzbarsky-apple @hawk248 @jelderton @andy31415 @mspang @saurabhst @BroderickCarlin @mspang | ||
| *.gn @chrisdecenzo @woody-apple @bzbarsky-apple @hawk248 @jelderton @andy31415 @mspang @saurabhst @BroderickCarlin @mspang | ||
| *.gni @chrisdecenzo @woody-apple @bzbarsky-apple @hawk248 @jelderton @andy31415 @mspang @saurabhst @BroderickCarlin @mspang | ||
| * @reviewers-amazon @reviewers-apple @reviewers-comcast @reviewers-google @reviewers-samsung |
There was a problem hiding this comment.
hope this line works, we had trouble with it while you were on vacation, but perhaps that was because there were more lines in this file confusing github
There was a problem hiding this comment.
worked before :)
mspang
approved these changes
Sep 25, 2020
|
With this landed, pullaprove seems to be consistently failing with:
|
|
yeah, @woody-apple will look as soon as he has time. this wasn't intended to land quite yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to make our approver requirements a little more dynamic, let's use pull approve to do so :)
Summary of Changes
Set up reviewer groups for parts of the tree, applied them as optional