[Linux] C++ version of autoptr for glib objects #28304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248 and
hicklin
|
PR #28304: Size comparison from 7ab043c to c0e63f3 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #28304: Size comparison from 7ab043c to 5b14884 Increases (5 builds for bl702, linux, nrfconnect)
Decreases (5 builds for bl602, bl702l, linux, qpg)
Full report (14 builds for bl602, bl702, bl702l, cc32xx, linux, mbed, nrfconnect, qpg)
|
|
PR #28304: Size comparison from 7ab043c to 96fdb32 Increases (10 builds for cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Decreases (18 builds for bl602, bl702, bl702l, efr32, linux, psoc6, telink)
Full report (49 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #28304: Size comparison from 7ab043c to 12a4fc9 Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (15 builds for linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jul 28, 2023
andy31415
previously requested changes
Jul 28, 2023
|
PR #28304: Size comparison from 2a681e3 to 717f724 Increases (23 builds for bl702l, cc32xx, esp32, k32w, linux, psoc6, telink)
Decreases (21 builds for bl602, bl702, efr32, linux, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 7, 2023
andy31415
approved these changes
Aug 10, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Remove CHIPOBLE ifdefs in files included by GN * Pass arguments as const if possible * Fix typo in enum name * Get rid of excessive casting * Fix memory leak on new CHIP device scanned * Free memory returned by g_variant_lookup_value * Move glib deleter helpers to lib/support * Define GAutoPtr for glib objects memory management * Build break fix * Fix build break without WPA * Add missing include * Move GLibTypeDeleter.h to src/platform
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
* Remove CHIPOBLE ifdefs in files included by GN * Pass arguments as const if possible * Fix typo in enum name * Get rid of excessive casting * Fix memory leak on new CHIP device scanned * Free memory returned by g_variant_lookup_value * Move glib deleter helpers to lib/support * Define GAutoPtr for glib objects memory management * Build break fix * Fix build break without WPA * Add missing include * Move GLibTypeDeleter.h to src/platform
This was referenced Sep 20, 2023
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
GAutoPtr<>template which acts asg_autoptr(as a global helper include file)constif possible and get rid of excessive castingBluezDevice1 * devicehas been converted to references in order to get rid of runtimenullptrchecks#if ...CHIPOBLEguards in files added to compilation by GNThere are going to be follow-up PRs which will replace glib explicit memory management with
GAutoPtr<>.Testing
CI will test for potential build breaks.
Commissioning tested with valgrind: