-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink]: Replaced manual bootloader configuration by conf file #28260
[Telink]: Replaced manual bootloader configuration by conf file #28260
Conversation
d13ea6b
to
b56fc82
Compare
PR #28260: Size comparison from 7b6cbc5 to b56fc82 Increases (14 builds for bl602, bl702, bl702l, esp32, qpg, telink)
Decreases (9 builds for cyw30739, efr32, esp32, k32w, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
b56fc82
to
c366dd9
Compare
PR #28260: Size comparison from ed545c4 to 06ee1d4 Increases (9 builds for bl702, cyw30739, psoc6, qpg, telink)
Decreases (12 builds for bl702, bl702l, efr32, esp32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@bzbarsky-apple |
@mishadesh This needs a review from a second reviewer. Ideally a telink platform owner.... My review was a rubber-stamp so it's not blocked once that telink owner review exists. |
Replaced manual definition-based overlays by conf file Signed-off-by: Misha Tkachenko <misha.tkachenko@telink-semi.com>
06ee1d4
to
d5fba85
Compare
But our telink platform doesn't have an owner. How can we request a right to become an owner? |
PR #28260: Size comparison from 67324e6 to d5fba85 Increases (6 builds for nrfconnect, qpg, telink)
Decreases (14 builds for bl602, bl702l, efr32, esp32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28260: Size comparison from 1d49d9e to 2fcfeba Increases (14 builds for bl602, bl702l, esp32, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, cc32xx, efr32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@s07641069 is a Telink owner I believe |
Sure it does. It's anyone in whatever set the telink platform maintainers say are the owners. |
Fast-tracking platform specific change with platform owner review. |
Replaced manual definition-based overlays by conf file
The previous solution to configure the bootloader for Telink build was just adding the definitions directly to build command.
The new solution replaces the definitions by bootloader.conf file and applies it by overlay.