Json tracing updates and fixes (enable in all clusters, fix lists and large payloads) #28022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andy31415
commented
Jul 18, 2023
andy31415
commented
- Enables full tracing for all-clusters-app as it is a very common test app
- Increases size for hex buffer to 4096 as we have found messages that are very large to potentially need encoding
- Fix duplicate key bug in json tracing (all keys in a list are "[]" and this meant at least for lists, json tracing was losing data)
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
andy31415
changed the title
bzbarsky-apple
approved these changes
Jul 18, 2023
bzbarsky-apple
approved these changes
Jul 18, 2023
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
tcarmelveilleux
approved these changes
Jul 18, 2023
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
… large payloads) (project-chip#28022) * Fix json tracing * Increase the buffer size for json tracing as well * Full json trace decoding for all clusters app on linux * Better formatting of lists - make indices make sense * Restyle * Updated comments based on code review * Restyled by whitespace * Add error logging when exit container fails * Fix typo * Update src/tracing/json/json_tracing.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * rename [] to Anonymous<> for lists * Rename exit to end for containers * Use a `@` format instead of - * One more anonymous update * Fix unit tests --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.