Generate lock operation events after lock state has changed #27991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarc
force-pushed
the
26925-lock-operation-events-after-lock-state-change
branch
from
cc6375a
to
c524dab
Compare
…n-events-after-lock-state-change
jrhees-cae
reviewed
Jul 18, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin and
jelderton
mmarc
force-pushed
the
26925-lock-operation-events-after-lock-state-change
branch
from
ce8436f
to
88c0999
Compare
mmarc
force-pushed
the
26925-lock-operation-events-after-lock-state-change
branch
from
88c0999
to
53e551b
Compare
…n-events-after-lock-state-change
jrhees-cae
reviewed
Jul 20, 2023
bzbarsky-apple
approved these changes
Jul 20, 2023
pullapprove
bot
requested review from
aronrosenberg,
mlepage-google and
robszewczyk
mmarc
force-pushed
the
26925-lock-operation-events-after-lock-state-change
branch
from
9f91729
to
dad4b1c
Compare
… remote actions
…n-events-after-lock-state-change
bzbarsky-apple
approved these changes
Jul 21, 2023
jrhees-cae
approved these changes
Jul 22, 2023
cecille
reviewed
Jul 22, 2023
cecille
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26925
fabricIdxandnodeIdare now passed to the LockEndpoint so that they can be then later forwarded again back to thedoor-lock-serverwhen updating the lock state.So now with remote operations (same as with other operations before) the
LockOperationEventis generated together with the change of the lock state.Only exception is if an error occurs (credential/pin error) before the execution. That error will be returned directly to the
HandleRemoteLockOperationand stored immediately.