[other] Add to flake8 in workflow and fix python files (part #25193)

.flake8

@@ -4,21 +4,3 @@ exclude = third_party
           .*
           out/*
           ./examples/common/QRCode/*
-          # temporarily scan only directories with fixed files
-          # TODO: Remove the paths below when all bugs are fixed
-          build/chip/java/tests/*
-          build/chip/linux/*
-          build/config/linux/*
-          credentials/fetch-paa-certs-from-dcl.py
-          docs/_extensions/external_content.py
-          examples/common/pigweed/rpc_console/py/chip_rpc/console.py
-          examples/lighting-app/python/lighting.py
-          src/app/zap_cluster_list.py
-          src/controller/python/chip/yaml/__init__.py
-          src/controller/python/chip/yaml/format_converter.py
-          src/controller/python/chip/yaml/runner.py
-          src/controller/python/py_matter_yamltest_repl_adapter/matter_yamltest_repl_adapter/runner.py
-          src/lib/asn1/gen_asn1oid.py
-          src/pybindings/pycontroller/build-chip-wheel.py
-          src/pybindings/pycontroller/pychip/__init__.py
-          src/setup_payload/python/generate_setup_payload.py

build/chip/linux/gen_gdbus_wrapper.py

@@ -65,10 +65,10 @@ def main(argv):
                       ] + extra_args + [options.input_file]
         subprocess.check_call(gdbus_args)
         sed_args = ["sed", "-i",
-                    "s/config\.h/BuildConfig.h/g", options.output_c]
+                    r"s/config\.h/BuildConfig.h/g", options.output_c]
         if sys.platform == "darwin":
             sed_args = ["sed", "-i", "",
-                        "s/config\.h/BuildConfig.h/g", options.output_c]
+                        r"s/config\.h/BuildConfig.h/g", options.output_c]
         subprocess.check_call(sed_args)
 
     if options.output_h:

build/config/linux/pkg-config.py

@@ -108,7 +108,7 @@ def MatchesAnyRegexp(flag, list_of_regexps):
     """Returns true if the first argument matches any regular expression in the
     given list."""
     for regexp in list_of_regexps:
-        if regexp.search(flag) != None:
+        if regexp.search(flag) is not None:
             return True
     return False
 
@@ -145,7 +145,7 @@ def main():
 
     # Make a list of regular expressions to strip out.
     strip_out = []
-    if options.strip_out != None:
+    if options.strip_out is not None:
         for regexp in options.strip_out:
             strip_out.append(re.compile(regexp))
 

credentials/fetch-paa-certs-from-dcl.py

@@ -26,7 +26,6 @@
 import re
 import subprocess
 import sys
-from contextlib import nullcontext
 
 import click
 import requests

docs/_extensions/external_content.py

@@ -81,7 +81,7 @@ def adjust_includes(
 
     def _adjust_path(path):
         # ignore absolute paths, section links, hyperlinks and same folder
-        if path.startswith(("/", "#", "http", "www")) or not "/" in path:
+        if path.startswith(("/", "#", "http", "www")) or "/" not in path:
             return path
 
         # for files that are being copied modify reference to and out of /docs

examples/common/pigweed/rpc_console/py/chip_rpc/console.py

@@ -304,11 +304,11 @@ def write_to_output(data: bytes,
 
 def _read_raw_serial(read: Callable[[], bytes], output):
     """Continuously read and pass to output."""
-    with ThreadPoolExecutor() as executor:
+    with ThreadPoolExecutor() as _:
         while True:
             try:
                 data = read()
-            except Exception as exc:  # pylint: disable=broad-except
+            except Exception:  # pylint: disable=broad-except
                 continue
             if data:
                 output(data)

examples/lighting-app/python/lighting.py

@@ -21,11 +21,9 @@
 import textwrap
 import threading
 from cmd import Cmd
-from ctypes import CFUNCTYPE, c_char_p, c_int32, c_uint8
 
-from chip.exceptions import ChipStackError
-from chip.server import GetLibraryHandle, NativeLibraryHandleMethodArguments, PostAttributeChangeCallback
-from dali.address import Broadcast, Short
+from chip.server import GetLibraryHandle, PostAttributeChangeCallback
+from dali.address import Broadcast
 from dali.driver.hid import tridonic
 from dali.gear.general import DAPC, Off, RecallMaxLevel
 
@@ -206,7 +204,7 @@ def __init__(self):
 
 
 if __name__ == "__main__":
-    l = Lighting()
+    lighting = Lighting()
 
     lightMgrCmd = LightingMgrCmd()
     print("Chip Lighting Device Shell")

src/app/zap_cluster_list.py

@@ -21,7 +21,7 @@ def get_cluster_sources(clusters: typing.Set[str],
     cluster_sources: typing.Set[str] = set()
 
     for cluster in clusters:
-        if not cluster in source_map:
+        if cluster not in source_map:
             raise ValueError("Unhandled %s cluster: %s"
                              " (hint: add to src/app/zap_cluster_list.py)" % (side, cluster))
 

src/controller/python/chip/yaml/runner.py

@@ -129,7 +129,7 @@ def __init__(self, test_step):
             raise ActionCreationError(f'Default cluster {test_step.cluster} {test_step.command}, not supported')
 
     async def run_action(self, dev_ctrl: ChipDeviceController) -> _ActionResult:
-        resp = await _PSEUDO_CLUSTERS.execute(self._test_step)
+        _ = await _PSEUDO_CLUSTERS.execute(self._test_step)
         return _ActionResult(status=_ActionStatus.SUCCESS, response=None)
 
 

src/controller/python/py_matter_yamltest_repl_adapter/matter_yamltest_repl_adapter/runner.py

@@ -14,15 +14,15 @@
 
 # isort: off
 
-from chip import ChipDeviceCtrl  # Needed before chip.FabricAdmin
+from chip import ChipDeviceCtrl  # Needed before chip.FabricAdmin # noqa: F401
 import chip.FabricAdmin  # Needed before chip.CertificateAuthority
 
 # isort: on
 
 import chip.CertificateAuthority
 import chip.logging
 import chip.native
-from chip.ChipStack import *
+from chip.ChipStack import ChipStack
 from chip.yaml.runner import ReplTestRunner
 from matter_yamltests.runner import TestRunner
 
@@ -45,7 +45,7 @@ async def start(self):
 
         commission_device = False
         if len(certificate_authority_manager.activeCaList) == 0:
-            if self._commission_on_network_dut == False:
+            if self._commission_on_network_dut is False:
                 raise Exception(
                     'Provided repl storage does not contain certificate. Without commission_on_network_dut, there is no reachable DUT')
             certificate_authority_manager.NewCertificateAuthority()

src/setup_payload/python/generate_setup_payload.py

@@ -21,7 +21,6 @@
 
 import Base38
 from bitarray import bitarray
-from bitarray.util import ba2int
 from stdnum.verhoeff import calc_check_digit
 
 # See section 5.1.4.1 Manual Pairing Code in the Matter specification v1.0