-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python tools] Add to flake8 in workflow and fix python files (part #25193) #27881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27881: Size comparison from bdee512 to 6eaf5a1 Increases (8 builds for bl602, bl702, esp32, telink)
Decreases (9 builds for bl702, bl702l, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
requested changes
Jul 11, 2023
6eaf5a1
to
3fb0309
Compare
Damian-Nordic
approved these changes
Jul 11, 2023
PR #27881: Size comparison from aaa2542 to 3fb0309 Increases (9 builds for cc32xx, esp32, psoc6, qpg, telink)
Decreases (10 builds for bl602, esp32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Jul 11, 2023
@Damian-Nordic Sorry, looks like you have a merge conflict now :( |
bzbarsky-apple
approved these changes
Jul 12, 2023
3fb0309
to
a95bf0d
Compare
PR #27881: Size comparison from 9bf0fe6 to a95bf0d Increases (10 builds for bl602, bl702, psoc6, telink)
Decreases (12 builds for bl702, bl702l, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a part of #25193 ( part fix python files in python tools )
Problem
Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.
Changes
Fix all python files in python tools where linter find problem. Adding python tests to check with flake8.
Testing
CI will test and maybe some another manual testing