-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we don't use CHIP_CONFIG_MAX_FABRICS before it's defined. #27679
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:session-pool-size-max-fabrics
Jul 7, 2023
Merged
Make sure we don't use CHIP_CONFIG_MAX_FABRICS before it's defined. #27679
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:session-pool-size-max-fabrics
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of CHIP_CONFIG_SECURE_SESSION_POOL_SIZE uses CHIP_CONFIG_MAX_FABRICS but came before we ensures CHIP_CONFIG_MAX_FABRICS is defined. This change just moves it to right after the definition of CHIP_CONFIG_MAX_FABRICS.
PR #27679: Size comparison from 53e06c7 to db5972e Increases (9 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702l, esp32, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jul 7, 2023
arkq
approved these changes
Jul 7, 2023
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…it's defined. (project-chip#27679) The definition of CHIP_CONFIG_SECURE_SESSION_POOL_SIZE uses CHIP_CONFIG_MAX_FABRICS but came before we ensures CHIP_CONFIG_MAX_FABRICS is defined. This change just moves it to right after the definition of CHIP_CONFIG_MAX_FABRICS.
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
… before it's defined. (project-chip#27679)" This reverts commit a402f72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of CHIP_CONFIG_SECURE_SESSION_POOL_SIZE uses CHIP_CONFIG_MAX_FABRICS but came before we ensures CHIP_CONFIG_MAX_FABRICS is defined. This change just moves it to right after the definition of CHIP_CONFIG_MAX_FABRICS.