-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Java] Decouple generated API in build option #27624
Merged
mergify
merged 8 commits into
project-chip:master
from
joonhaengHeo:decouple_generated_api
Jul 25, 2023
Merged
[ Java] Decouple generated API in build option #27624
mergify
merged 8 commits into
project-chip:master
from
joonhaengHeo:decouple_generated_api
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 5, 2023 07:06
PR #27624: Size comparison from a9773c9 to d907dad Increases (9 builds for cyw30739, nrfconnect, telink)
Decreases (13 builds for bl602, bl702, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jul 5, 2023
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 8, 2023 06:31
andy31415
approved these changes
Jul 25, 2023
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Jul 25, 2023
andy31415
added a commit
that referenced
this pull request
Jul 25, 2023
cliffamzn
pushed a commit
to cliffamzn/connectedhomeip
that referenced
this pull request
Jul 25, 2023
* Decouple Java generated API * Add comment * restyle * remove tlvdecoder in controller library * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
cliffamzn
pushed a commit
to cliffamzn/connectedhomeip
that referenced
this pull request
Jul 25, 2023
…27624)" (project-chip#28272) This reverts commit 1ed2425. Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27398