-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LastChangedTime
to Resource Monitoring Cluster Definition
#27603
Merged
mergify
merged 4 commits into
project-chip:master
from
tobiasgraf:27570-add-lastchangedtime-to-resource-monitoring-cluster-definition
Jul 6, 2023
Merged
Add LastChangedTime
to Resource Monitoring Cluster Definition
#27603
mergify
merged 4 commits into
project-chip:master
from
tobiasgraf:27570-add-lastchangedtime-to-resource-monitoring-cluster-definition
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27603: Size comparison from b3002c6 to 9768c49 Increases above 0.2%:
Increases (20 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, esp32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LastChangedTime
to Resource Monitoring Cluster Definition
p0fi
approved these changes
Jul 3, 2023
andy31415
approved these changes
Jul 3, 2023
tcarmelveilleux
approved these changes
Jul 5, 2023
andy31415
reviewed
Jul 5, 2023
src/app/zap-templates/zcl/data-model/chip/resource-monitoring-cluster.xml
Show resolved
Hide resolved
andy31415
approved these changes
Jul 5, 2023
…edtime-to-resource-monitoring-cluster-definition # Conflicts: # src/controller/java/zap-generated/chip/devicecontroller/ChipIdLookup.java
PR #27603: Size comparison from fcf37c2 to 1334bdd Increases above 0.2%:
Increases (19 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl702, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…edtime-to-resource-monitoring-cluster-definition # Conflicts: # src/darwin/Framework/CHIP/zap-generated/MTRAttributeSpecifiedCheck.mm # src/darwin/Framework/CHIP/zap-generated/MTRAttributeTLVValueDecoder.mm # src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h # src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm # src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h # src/darwin/Framework/CHIP/zap-generated/MTRClusters.h # src/darwin/Framework/CHIP/zap-generated/MTRClusters.mm # zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h
jmeg-sfy
approved these changes
Jul 6, 2023
PR #27603: Size comparison from ffc026f to b579fa5 Increases above 0.2%:
Increases (21 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, psoc6, telink)
Decreases (7 builds for cyw30739, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR adds the
LastChangedTime
Attribute to the resource-monitoring-cluster.xmlThe
ReplacementProductList
will be handled by this issue #27571🔎 Details
zap_regen_all.py
🧪 How Has This Been Tested
./scripts/examples/gn_build_example.sh examples/chip-tool out/chip-tool
🔗 Links/References
LastChangedTime
to Resource Monitoring Cluster Definition #27570