Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadHandler] Report Scheduler class #27553

Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7328172
Added a new class that will handle the scheduling of reports.
lpbeliveau-silabs Jun 27, 2023
c1930a3
Restyled by clang-format
restyled-commits Jun 29, 2023
ed7bfac
Removed un-necessary define in TestReportScheduler and applied refact…
lpbeliveau-silabs Jun 29, 2023
e9812ae
Added TimerDelegate and wrapper functions around calls to Timer. Remo…
lpbeliveau-silabs Jun 29, 2023
498716e
Added VerifyOrReturn after NL_TEST_ASSERTS for nullptr
lpbeliveau-silabs Jun 30, 2023
9a16c68
Completed TimerDelegate class and modified ReadHandlerNodes so they c…
lpbeliveau-silabs Jun 30, 2023
48454fb
Modified TimerDelegate to allow to pass different objects as context
lpbeliveau-silabs Jul 4, 2023
02bf98a
ifdefing out ScheduleRun() to debug failing CI
lpbeliveau-silabs Jul 5, 2023
5e38e01
Added issue # to TODOs, refactored Min/Max Intervals to Min/Max Times…
lpbeliveau-silabs Jul 6, 2023
7c2cf2f
Clarified some comments regarding timing
lpbeliveau-silabs Jul 6, 2023
58df486
Restyled by whitespace
restyled-commits Jul 6, 2023
bfb69d9
Restyled by clang-format
restyled-commits Jul 6, 2023
6d92863
Added interface to GetMonotonicTimestamp in the timer delegate
lpbeliveau-silabs Jul 11, 2023
86aec76
Apply suggestions from code review
lpbeliveau-silabs Jul 11, 2023
64f5041
Completed renaming to eliminate compiling error, moved TestReporScehd…
lpbeliveau-silabs Jul 11, 2023
f015837
Removed useless objects from tests as well as useless typecasting, an…
lpbeliveau-silabs Jul 12, 2023
97683ad
Fixed comment about private methods used in ReportScheduler as a frie…
lpbeliveau-silabs Jul 12, 2023
e81641d
Changed to SetMinReportInterval to SetMinReportingIntervalForTests, r…
lpbeliveau-silabs Jul 13, 2023
2a55ac5
Apply suggestions from code review
lpbeliveau-silabs Jul 13, 2023
a0b9d6e
Restyled by clang-format
restyled-commits Jul 13, 2023
4df646c
Removed all calls to ReadHandler States to prevent Engine calls from …
lpbeliveau-silabs Jul 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed comment about private methods used in ReportScheduler as a frie…
…nd class
  • Loading branch information
lpbeliveau-silabs committed Jul 12, 2023
commit 97683adfb21383cce86b69400e06ace89b0b0420
2 changes: 1 addition & 1 deletion src/app/ReadHandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ class ReadHandler : public Messaging::ExchangeDelegate
friend class chip::app::reporting::Engine;
friend class chip::app::InteractionModelEngine;

// The report scheduler needs to be able to access StateFlag private functions IsReadHandlerReportable and IsChunkedReport to
// The report scheduler needs to be able to access StateFlag private functions IsGeneratingReports() and IsDirty() to
// know when to schedule a run so it is declared as a friend class.
friend class chip::app::reporting::ReportScheduler;

Expand Down
Loading