Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method return type (strict python noticed we return None here) #27156

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Fix method return type (strict python noticed we return None here) #27156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
409ee1a
Fix method return type (strict python noticed we return None here)
andreilitvin Jun 8, 2023
b4d956d
Fix typo
andreilitvin Jun 8, 2023
d6dab48
Merge branch 'master' into fix_return_type
andy31415 Jun 8, 2023
fa60806
Fix a typo
andy31415 Jun 8, 2023
72090f8
Revert unintended repo change
andy31415 Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/py_matter_idl/matter_idl/lint/lint_rules_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import xml.etree.ElementTree
from dataclasses import dataclass
from enum import Enum, auto
from typing import List, MutableMapping, Tuple, Union
from typing import List, MutableMapping, Optional, Tuple, Union

from lark import Lark
from lark.visitors import Discard, Transformer, v_args
Expand Down Expand Up @@ -167,7 +167,7 @@ def GetLinterRules(self):
def RequireAttribute(self, r: AttributeRequirement):
self._required_attributes_rule.RequireAttribute(r)

def FindClusterCode(self, name: str) -> Tuple[str, int]:
def FindClusterCode(self, name: str) -> Optional[Tuple[str, int]]:
if name not in self._cluster_codes:
# Name may be a number. If this can be parsed as a number, accept it anyway
try:
Expand Down
2 changes: 1 addition & 1 deletion src/lib/support/StringSplitter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class StringSplitter
}
}

/// Returns the next character san
/// Returns the next character span
///
/// out - contains the next element or a nullptr/0 sized span if
/// no elements available
Expand Down