-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Align the return values of all commission interfaces #27064
[Python] Align the return values of all commission interfaces #27064
Conversation
PR #27064: Size comparison from 275341e to 5934cfa Increases (1 build for bl702)
Decreases (3 builds for bl602, bl702, cc32xx)
Full report (15 builds for bl602, bl702, cc32xx, k32w, linux, nrfconnect, qpg)
|
PR #27064: Size comparison from 275341e to c35dd1e Increases (8 builds for bl702, psoc6, telink)
Decreases (9 builds for bl602, cc32xx, cyw30739, esp32, psoc6, telink)
Full report (62 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go back to returning a single value from commissioning method, but wrap the PyChipError inside of it (see suggestion in line of code)
…o fixes/python-assign-commission-returned-value
@tcarmelveilleux Adopted your suggestion to use PyChipError as a unified return value |
PR #27064: Size comparison from fd9721d to 14e5d81 Increases (11 builds for bl602, bl702, cc32xx, cyw30739, k32w, psoc6, telink)
Decreases (10 builds for nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…o fixes/python-assign-commission-returned-value
PR #27064: Size comparison from b611144 to db7dc28 Decreases (5 builds for bl702, cc32xx, esp32, psoc6, qpg)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27064: Size comparison from 643f7aa to 7a37327 Increases (8 builds for esp32, nrfconnect, telink)
Decreases (13 builds for bl702, cc32xx, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…o fixes/python-assign-commission-returned-value
…b.com:tianfeng-yang/connectedhomeip into fixes/python-assign-commission-returned-value
…o fixes/python-assign-commission-returned-value
PR #27064: Size comparison from 69ffbed to 5aece8f Increases (4 builds for esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for cc32xx, esp32, nrfconnect, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
The
CommissionOnNetwork
interface returnsTuple[bool, PyChipError]
, other commission interfaces only returnbool
, align the return values of all interfaces