Immediately perform colour transitions for ColorControl commands where TransitionTime is zero #26987
Commits on May 31, 2023
-
Perform colour control commands with zero transition time immediately.
Commands to the colour control server that had a transition time of zero were being deferred for 100 ms. Instead they should be handled immediately.
-
Ensure the RemainingTime attribute is set correctly.
When the transition time is 0, the remaining time should also be 0.
Commits on Jun 1, 2023
-
Track the time remaining for a colour-change command separately from …
…the number of steps remaining. This ensures the calculation for time remaining is correct when both a hue and a saturation command are running simultaneously.
-
Calculate the amount of time to delay the first step where it's used instead of at the start of the functions.
-
Remove the transitionTime variable.
Calculate the value where it's used instead.
Commits on Jun 5, 2023
Commits on Jun 6, 2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.