-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a lint for SuccessOrExit without assignment. #26854
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:success-or-exit-lint
May 26, 2023
Merged
Add a lint for SuccessOrExit without assignment. #26854
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:success-or-exit-lint
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26854: Size comparison from f5c1e5c to a93d5b4 Increases (40 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (27 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg)
|
This is almost always a mistake, since it loses track of the error involved.
a93d5b4
to
2109d61
Compare
PR #26854: Size comparison from 4b04598 to 2109d61 Increases (55 builds for bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (45 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cyw30739, efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (70 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
May 25, 2023
bzbarsky-apple
commented
May 26, 2023
PR #26854: Size comparison from 4b04598 to 01e866a Increases (52 builds for bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (46 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (70 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 26, 2023
@bzbarsky-apple Is it possible to cherry-pick this fix in v1.1-branch? |
@dhrishi Probably? I don't have time/bandwidth for it right now, but if you try and it fails let me know and I can try to make the time. |
@bzbarsky-apple Sure. Will do that! |
dhrishi
pushed a commit
to dhrishi/connectedhomeip
that referenced
this pull request
Jun 2, 2023
* Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment.
dhrishi
pushed a commit
to dhrishi/connectedhomeip
that referenced
this pull request
Jun 2, 2023
* Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment.
dhrishi
pushed a commit
to dhrishi/connectedhomeip
that referenced
this pull request
Jun 2, 2023
* Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment.
andy31415
pushed a commit
that referenced
this pull request
Jun 2, 2023
hawkhan
pushed a commit
to Ayla-Professional-Service/csa_matter
that referenced
this pull request
Dec 20, 2023
* Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment.
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…ect-chip#26854) (project-chip#27029) * Add a lint for SuccessOrExit without assignment. This is almost always a mistake, since it loses track of the error involved. * Address review comment. Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> (cherry picked from commit 0f8fac1)
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…t. (project-chip#26854) (project-chip#27029)" This reverts commit 29abb73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost always a mistake, since it loses track of the error involved.