-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Update ICD Management XML to match specification #26587
Merged
jmartinez-silabs
merged 15 commits into
project-chip:master
from
mkardous-silabs:feature/icd_xml
May 16, 2023
Merged
[ICD] Update ICD Management XML to match specification #26587
jmartinez-silabs
merged 15 commits into
project-chip:master
from
mkardous-silabs:feature/icd_xml
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
May 15, 2023 20:54
PR #26587: Size comparison from 5f1a60b to b1f6d51 Increases (4 builds for cc32xx, linux, nrfconnect)
Decreases (2 builds for linux, qpg)
Full report (9 builds for cc32xx, linux, mbed, nrfconnect, qpg)
|
jmartinez-silabs
approved these changes
May 16, 2023
src/app/zap-templates/zcl/data-model/chip/icd-management-cluster.xml
Outdated
Show resolved
Hide resolved
PR #26587: Size comparison from 5f1a60b to e229e34 Increases above 0.2%:
Increases (20 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (27 builds for bl702, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
force-pushed
the
feature/icd_xml
branch
from
May 16, 2023 15:07
e229e34
to
6cc4b1f
Compare
PR #26587: Size comparison from 72e7659 to 6cc4b1f Increases above 0.2%:
Increases (12 builds for bl602, bl702, cc32xx, linux, nrfconnect, psoc6)
Decreases (9 builds for bl702, cyw30739, k32w, linux, nrfconnect, psoc6, qpg)
Full report (24 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #26587: Size comparison from 72e7659 to 86d0f18 Increases (1 build for cc32xx)
Decreases (2 builds for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
mkardous-silabs
force-pushed
the
feature/icd_xml
branch
from
May 16, 2023 16:44
86d0f18
to
6cc4b1f
Compare
mkardous-silabs
force-pushed
the
feature/icd_xml
branch
from
May 16, 2023 16:52
26827d3
to
f88c14b
Compare
PR #26587: Size comparison from 06921da to f88c14b Increases above 0.2%:
Increases (19 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (32 builds for bl602, bl702, cyw30739, efr32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 16, 2023
tianfeng-yang
pushed a commit
to tianfeng-yang/connectedhomeip
that referenced
this pull request
May 17, 2023
…26587) * Update ICD management cluster xml * generated files * Enable ICDM for controller * generated files * update files cm -> icdm * enable CheckIn features * generated files * fix comments * Address PR review comments * Fix ESP build * Fix typo * generated files * change featuremap default * regen * Encode empty list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update XML file and add code skeleton
Tests
Manual tests that commands can be sent and processed