Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inet implementations assume BYTE_ORDER is defined. make sure that it is #26460

Merged
merged 4 commits into from
May 10, 2023
Merged

Inet implementations assume BYTE_ORDER is defined. make sure that it is #26460

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
457b72d
BYTE_ORDER must be defined in the project
jmartinez-silabs May 9, 2023
58d9277
fix typo
jmartinez-silabs May 9, 2023
7d09a84
Remove BYTE_ORDER from the file. Only use __BYTE_ORDER__ and relative…
jmartinez-silabs May 10, 2023
114800e
Apply suggestions from code review
jmartinez-silabs May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/inet/arpa-inet-compatibility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#else // !CHIP_SYSTEM_CONFIG_USE_SOCKETS

#if CHIP_SYSTEM_CONFIG_USE_LWIP

#include <lwip/def.h>
#include <lwip/opt.h>

Expand All @@ -49,7 +48,11 @@

#if CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT

#if BYTE_ORDER == BIG_ENDIAN
#ifndef __BYTE_ORDER__
#error Endianness not defined is not defined
jmartinez-silabs marked this conversation as resolved.
Show resolved Hide resolved
#endif // BYTE_ORDER

#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
#ifndef htons
#define htons(x) (x)
#endif
Expand All @@ -63,7 +66,7 @@
#define ntohl(x) (x)
#endif

#else // BYTE_ORDER != BIG_ENDIAN
#elif __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
#ifndef htons
#define htons(x) ((u16_t)((((x) & (u16_t) 0x00ffU) << 8) | (((x) & (u16_t) 0xff00U) >> 8)))
#endif
Expand All @@ -78,7 +81,10 @@
#ifndef ntohl
#define ntohl(x) htonl(x)
#endif
#endif // BYTE_ORDER == BIG_ENDIAN

#else
#error Unknown endiannes set to _BYTE_ORDER__
jmartinez-silabs marked this conversation as resolved.
Show resolved Hide resolved
#endif // _BYTE_ORDER__ ==
jmartinez-silabs marked this conversation as resolved.
Show resolved Hide resolved

#endif // CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT

Expand Down