Add extra bootstrap hint to gn_build.sh #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty confusing right now due to the transition, and has tripped up multiple people. Add an extra note before bootstrap about what "run bootstrap" means for us.
mspang
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
rwalker-apple and
saurabhst
as code owners
yunhanw-google
approved these changes
Sep 14, 2020
saurabhst
approved these changes
Sep 14, 2020
bzbarsky-apple
approved these changes
Sep 14, 2020
rwalker-apple
approved these changes
Sep 14, 2020
kedars
approved these changes
Sep 15, 2020
BroderickCarlin
approved these changes
Sep 16, 2020
andy31415
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty confusing right now due to the transition, and has
tripped up multiple people. Add an extra note before bootstrap about
what "run bootstrap" means for us.
Problem
Instruction to "Run bootstrap" is not clear while we still have multiple bootstraps.
Summary of Changes
Add a note saying which bootstrap to run.