-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IDL parser for older lark #26145
Merged
andy31415
merged 3 commits into
project-chip:master
from
andy31415:idl_fixes_for_mypy_and_lark
Apr 18, 2023
Merged
Fix IDL parser for older lark #26145
andy31415
merged 3 commits into
project-chip:master
from
andy31415:idl_fixes_for_mypy_and_lark
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26145: Size comparison from 856963e to 2ca52b9 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
tcarmelveilleux
approved these changes
Apr 18, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
April 18, 2023 16:49
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
April 18, 2023 16:49
PR #26145: Size comparison from 856963e to 08e4ae6 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out lark had some backwards incompatible changes in meta placement first vs last argument when only
@v_args(meta=True)
is used.Switch code to use inline as well, which seems consistent across versions.
While checking this, also fixed some mypy checks for static typing.