Clean up for review

examples/all-clusters-app/nxp/mw320/BUILD.gn

@@ -63,7 +63,7 @@ mw320_executable("shell_mw320") {
     "${chip_root}/src/setup_payload",
   ]
 
-  deps = [ "${examples_plat_dir}:syscalls_stub" ]
+  deps = [ "${chip_root}/src/platform:syscalls_stub" ]
 
   include_dirs = [
     "${chip_root}/src/platform/nxp/mw320",

examples/contact-sensor-app/nxp/k32w/k32w0/BUILD.gn

@@ -108,9 +108,9 @@ k32w0_executable("contact_sensor_app") {
     "${chip_root}/examples/contact-sensor-app/contact-sensor-common",
     "${chip_root}/examples/providers:device_info_provider",
     "${chip_root}/src/lib",
+    "${chip_root}/src/platform:syscalls_stub",
     "${chip_root}/third_party/mbedtls:mbedtls",
     "${k32w0_platform_dir}/app/support:freertos_mbedtls_utils",
-    "${k32w0_platform_dir}/common:syscalls_stub",
   ]
 
   if (chip_openthread_ftd) {

examples/lighting-app/nxp/k32w/k32w0/BUILD.gn

@@ -110,9 +110,9 @@ k32w0_executable("light_app") {
     "${chip_root}/examples/lighting-app/nxp/zap/",
     "${chip_root}/examples/providers:device_info_provider",
     "${chip_root}/src/lib",
+    "${chip_root}/src/platform:syscalls_stub",
     "${chip_root}/third_party/mbedtls:mbedtls",
     "${k32w0_platform_dir}/app/support:freertos_mbedtls_utils",
-    "${k32w0_platform_dir}/common:syscalls_stub",
   ]
 
   if (chip_openthread_ftd) {

examples/lock-app/nxp/k32w/k32w0/BUILD.gn

@@ -109,10 +109,10 @@ k32w0_executable("lock_app") {
     "${chip_root}/examples/providers:device_info_provider",
     "${chip_root}/src/crypto",
     "${chip_root}/src/lib",
+    "${chip_root}/src/platform:syscalls_stub",
     "${chip_root}/third_party/mbedtls:mbedtls",
     "${chip_root}/third_party/simw-top-mini:se05x",
     "${k32w0_platform_dir}/app/support:freertos_mbedtls_utils",
-    "${k32w0_platform_dir}/common:syscalls_stub",
   ]
 
   if (chip_openthread_ftd) {

examples/shell/nxp/k32w/k32w0/BUILD.gn

@@ -67,10 +67,10 @@ k32w0_executable("shell_app") {
     "${chip_root}/examples/common/QRCode",
     "${chip_root}/examples/lock-app/lock-common",
     "${chip_root}/examples/shell/shell_common:shell_common",
+    "${chip_root}/src/platform:syscalls_stub",
     "${chip_root}/third_party/mbedtls:mbedtls",
     "${chip_root}/third_party/simw-top-mini:se05x",
     "${k32w0_platform_dir}/app/support:freertos_mbedtls_utils",
-    "${k32w0_platform_dir}/common:syscalls_stub",
   ]
 
   cflags = [ "-Wconversion" ]

src/platform/BUILD.gn

@@ -487,3 +487,7 @@ if (chip_device_platform != "none") {
     public_deps = [ ":platform_buildconfig" ]
   }
 }
+
+source_set("syscalls_stub") {
+  sources = ["SyscallStubs.cpp"]
+}

examples/platform/nxp/k32w/k32w0/common/syscalls_stubs.cpp → src/platform/SyscallStubs.cpp

@@ -42,12 +42,22 @@ int _lseek(int file, int ptr, int dir);
 int _read(int file, char * ptr, int len);
 int _write(int file, const char * ptr, int len);
 
+/**************************************************************************
+ * @brief
+ *  Open a file.
+ *
+ * @param[in] file
+ *  File you want to open.
+ *
+ * @return
+ *  Returns -1 since there is not logic here to open file.
+ **************************************************************************/
 int __attribute__((weak)) _open(const char * pathname, int flags, int mode)
 {
     (void) pathname;
     (void) flags;
     (void) mode;
-    return 0;
+    return -1;
 }
 
 /**************************************************************************

third_party/infineon/cyw30739_sdk/BUILD.gn

@@ -25,13 +25,13 @@ declare_args() {
 
 assert(cyw30739_sdk_target != "", "cyw30739_sdk_target must be specified")
 
-config("cyw30739_sdk_special_linker_config") {
+config("cyw30739_sdk_no_warn_rwx") {
   ldflags = [ "-Wl,--no-warn-rwx-segment" ]
 }
 
 group("cyw30739_sdk") {
   public_deps = [ cyw30739_sdk_target ]
-  all_dependent_configs = [ ":cyw30739_sdk_special_linker_config" ]
+  all_dependent_configs = [ ":cyw30739_sdk_no_warn_rwx" ]
 }
 
 config("mbedtls_cyw30739_config") {

third_party/infineon/psoc6/syscalls_stubs.cpp

@@ -42,12 +42,22 @@ int _lseek(int file, int ptr, int dir);
 int _read(int file, char * ptr, int len);
 int _write(int file, const char * ptr, int len);
 
+/**************************************************************************
+ * @brief
+ *  Open a file.
+ *
+ * @param[in] file
+ *  File you want to open.
+ *
+ * @return
+ *  Returns -1 since there is not logic here to open file.
+ **************************************************************************/
 int __attribute__((weak)) _open(const char * pathname, int flags, int mode)
 {
     (void) pathname;
     (void) flags;
     (void) mode;
-    return 0;
+    return -1;
 }
 
 /**************************************************************************