Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow code pre-generation to accept files outside of chip-root #25970

Merged
merged 14 commits into from
Apr 11, 2023
Merged

Allow code pre-generation to accept files outside of chip-root #25970

merged 14 commits into from
Apr 11, 2023

Conversation

andy31415
Copy link
Contributor

This allows passing external-root to the script to include codegen outside $CHIP_ROOT.

Updated documentation to describe how to generate .matter files and how to use this new option.

@github-actions github-actions bot added documentation Improvements or additions to documentation scripts labels Apr 4, 2023
bzbarsky-apple
bzbarsky-apple reviewed Apr 4, 2023
View reviewed changes
docs/code_generation.md Outdated Show resolved Hide resolved
docs/code_generation.md Outdated Show resolved Hide resolved
docs/code_generation.md Outdated Show resolved Hide resolved
docs/code_generation.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

PR #25970: Size comparison from 884c4e2 to 724953f

Full report (1 build for cc32xx)
platform target config section 884c4e2 724953f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644409 644409 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302986 20302986 0 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

andy31415 and others added 5 commits April 4, 2023 13:37
@andy31415 @bzbarsky-apple
Update docs/code_generation.md
ed29f57 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@andy31415 @bzbarsky-apple
Update docs/code_generation.md
88c4945 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@andy31415 @bzbarsky-apple
Update docs/code_generation.md
6f3d743 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@andreilitvin
Slight rephrase
d6c7d1e
@andreilitvin
Another rephrase
6c123f4
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

PR #25970: Size comparison from 884c4e2 to 6c123f4

Increases (1 build for cc32xx)
platform target config section 884c4e2 6c123f4 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302986 20302987 1 0.0
Full report (1 build for cc32xx)
platform target config section 884c4e2 6c123f4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644409 644409 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302986 20302987 1 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

PR #25970: Size comparison from 884c4e2 to 277b4d3

Full report (1 build for cc32xx)
platform target config section 884c4e2 277b4d33 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644409 644409 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302986 20302986 0 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

PR #25970: Size comparison from 884c4e2 to 7d37dea

Increases (1 build for cc32xx)
platform target config section 884c4e2 7d37dea change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20302986 20302987 1 0.0
Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
platform target config section 884c4e2 7d37dea change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644409 644409 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933099 933099 0 0.0
.debug_aranges 87608 87608 0 0.0
.debug_frame 301328 301328 0 0.0
.debug_info 20302986 20302987 1 0.0
.debug_line 2679748 2679748 0 0.0
.debug_loc 2824679 2824679 0 0.0
.debug_ranges 286200 286200 0 0.0
.debug_str 3039406 3039406 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105953 105953 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377422 377422 0 0.0
.symtab 256768 256768 0 0.0
.text 536336 536336 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466152 2466152 0 0.0
.bss 215964 215964 0 0.0
.data 5880 5880 0 0.0
.text 1428796 1428796 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1173596 1173596 0 0.0
bss 155557 155557 0 0.0
rodata 132652 132652 0 0.0
text 804616 804616 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1118828 1118828 0 0.0
bss 154713 154713 0 0.0
rodata 109468 109468 0 0.0
text 774008 774008 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1433604 1433604 0 0.0
bss 135297 135297 0 0.0
rodata 228692 228692 0 0.0
text 775536 775536 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1153680 1153680 0 0.0
.bss 97404 97404 0 0.0
.data 852 852 0 0.0
.text 600776 600776 0 0.0
lock-app qpg6105+debug (read/write) 1122216 1122216 0 0.0
.bss 92540 92540 0 0.0
.data 856 856 0 0.0
.text 569316 569316 0 0.0

@andy31415 andy31415 enabled auto-merge (squash) April 11, 2023 15:28
@andy31415 andy31415 merged commit ef05822 into project-chip:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @yunhanw-google @bzbarsky-apple @andreilitvin