[Android] Implement using generic IM(invoke,read,write,subscribe) APIs #25956

joonhaengHeo · 2023-04-04T07:19:38Z

The purpose of this PR is to:

Create Class that returns Cluster, Attribute, and Event ID (Using jinja)
Changed the function used in fragments of light on/of, level cluster, sensor cluster, multiple admin cluster, operational credential cluster, and basic cluster to Generic IM Function.

github-actions · 2023-04-04T07:36:29Z

PR #25956: Size comparison from d81d4e3 to b8289df

Decreases (1 build for cc32xx)

platform	target	config	section	`d81d4e3`	`b8289df`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20302987	20302986	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`d81d4e3`	`b8289df`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	644409	644409	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933099	933099	0	0.0
			.debug_aranges	87608	87608	0	0.0
			.debug_frame	301328	301328	0	0.0
			.debug_info	20302987	20302986	-1	-0.0
			.debug_line	`2679748`	`2679748`	0	0.0
			.debug_loc	2824679	2824679	0	0.0
			.debug_ranges	286200	286200	0	0.0
			.debug_str	`3039406`	`3039406`	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105953	105953	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377422	377422	0	0.0
			.symtab	256768	256768	0	0.0
			.text	536336	536336	0	0.0

src/controller/java/templates/ChipIdLookup-java.zapt

andy31415 · 2023-04-04T11:43:38Z

@joonhaengHeo please update the summary to explain the approach taken and how things are used. Ideally reviewers would read the summary to understand what to expect in the PR. Fixes ... forces me to go to a issue and even then, the issue describes just "use generic IM for ..." but does not explain how the implementation is done.

src/platform/android/java/chip/platform/NsdServiceFinderAndResolver.java

...oid/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/BasicClientFragment.kt

joonhaengHeo · 2023-04-05T22:48:07Z

@andy31415
Sorry for the confusion. The reason I posted this was not for the purpose of merging, but to share the current progress with others. As you said, I will write and upload it accurately at the time of PR.

github-actions · 2023-04-06T10:04:21Z

PR #25956: Size comparison from 14ffac0 to 64ffc4c

Full report (1 build for cc32xx)

platform	target	config	section	`14ffac0`	`64ffc4c`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	642745	642745
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933099	933099
			.debug_aranges	87608	87608
			.debug_frame	301328	301328
			.debug_info	20302987	20302987
			.debug_line	`2679748`	`2679748`
			.debug_loc	2824679	2824679
			.debug_ranges	286200	286200
			.debug_str	`3039406`	`3039406`
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104289	104289
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377422	377422
			.symtab	256768	256768
			.text	536336	536336

github-actions · 2023-04-07T01:08:59Z

PR #25956: Size comparison from 38580b0 to 1bd7320

Full report (1 build for cc32xx)

platform	target	config	section	`38580b0`	1bd7320c
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	642745	642745
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933119	933119
			.debug_aranges	87608	87608
			.debug_frame	301328	301328
			.debug_info	20302990	20302990
			.debug_line	2679759	2679759
			.debug_loc	2824679	2824679
			.debug_ranges	286200	286200
			.debug_str	`3039406`	`3039406`
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104289	104289
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	377422	377422
			.symtab	256768	256768
			.text	536336	536336

github-actions · 2023-04-17T02:21:25Z

PR #25956: Size comparison from 2e4064e to f40f8ca

Decreases (1 build for cc32xx)

platform	target	config	section	2e4064e1	`f40f8ca`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20328412	20328411	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	2e4064e1	`f40f8ca`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	643249	643249	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933224	933224	0	0.0
			.debug_aranges	87792	87792	0	0.0
			.debug_frame	302140	302140	0	0.0
			.debug_info	20328412	20328411	-1	-0.0
			.debug_line	2687890	2687890	0	0.0
			.debug_loc	2838930	2838930	0	0.0
			.debug_ranges	288072	288072	0	0.0
			.debug_str	3042155	3042155	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104401	104401	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	377963	377963	0	0.0
			.symtab	256976	256976	0	0.0
			.text	536728	536728	0	0.0

github-actions · 2023-04-20T04:10:27Z

PR #25956: Size comparison from e2341d8 to e9b776e

Full report (3 builds for mbed, qpg)

platform	target	config	section	`e2341d8`	`e9b776e`
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2466336`	`2466336`
			.bss	215960	215960
			.data	5888	5888
			.text	1428980	1428980
qpg	lighting-app	qpg6105+debug	(read/write)	1166568	1166568
			.bss	99308	99308
			.data	856	856
			.text	613668	613668
	lock-app	qpg6105+debug	(read/write)	1136688	1136688
			.bss	94452	94452
			.data	860	860
			.text	583784	583784

...id/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/SensorClientFragment.kt

src/controller/java/BUILD.gn

…ibe) APIs (project-chip#25956)" This reverts commit b51219b because Android CI has been failing ever since it merged (both smoketest and full).

bzbarsky-apple · 2023-05-19T21:50:40Z

@joonhaengHeo Unfortunately, this is failing Androir CI (probably because of a bad merge against other changes?). #26704 created to revert this so we can get the tree back into a passing-CI state.

…ibe) APIs (#25956)" (#26704) This reverts commit b51219b because Android CI has been failing ever since it merged (both smoketest and full).

…e,subscribe) APIs (project-chip#25956)" (project-chip#26704)" This reverts commit bfa0580.

…s - reupload (#26710) * Revert "Revert "[Android] Implement using generic IM(invoke,read,write,subscribe) APIs (#25956)" (#26704)" This reverts commit bfa0580. * Implement android generic im

github-actions bot added controller examples platform labels Apr 4, 2023

andy31415 reviewed Apr 4, 2023

View reviewed changes

src/controller/java/templates/ChipIdLookup-java.zapt Outdated Show resolved Hide resolved

andy31415 reviewed Apr 4, 2023

View reviewed changes

src/platform/android/java/chip/platform/NsdServiceFinderAndResolver.java Outdated Show resolved Hide resolved

andy31415 reviewed Apr 4, 2023

View reviewed changes

...oid/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/BasicClientFragment.kt Outdated Show resolved Hide resolved

joonhaengHeo force-pushed the implement_android_generic_im branch from b8289df to ceb0659 Compare April 6, 2023 02:36

github-actions bot removed the platform label Apr 6, 2023

joonhaengHeo force-pushed the implement_android_generic_im branch from ceb0659 to 64ffc4c Compare April 6, 2023 09:53

github-actions bot added the scripts label Apr 6, 2023

joonhaengHeo added 2 commits April 7, 2023 09:54

Add Cluster ID jinja file

0dd62c4

Update BasicInformation Cluster

1bd7320

joonhaengHeo force-pushed the implement_android_generic_im branch from 64ffc4c to 1bd7320 Compare April 7, 2023 00:55

joonhaengHeo self-assigned this Apr 7, 2023

Merge branch 'master' into implement_android_generic_im

f40f8ca

joonhaengHeo added 5 commits April 18, 2023 10:57

remove import

6639a18

modify test java file

7fd8238

regen zap

294c694

add command ID

8b25acd

Implement cluster command using generic im

b379cdf

joonhaengHeo marked this pull request as ready for review April 20, 2023 02:19

pullapprove bot requested review from amitnj, anush-apple and arkq April 20, 2023 02:19

pullapprove bot requested review from robszewczyk, saurabhst, selissia, sharadb-amazon, tcarmelveilleux, tecimovic, tehampson, vijs, vivien-apple, woody-apple, xylophone21, younghak-hwang and yufengwangca April 20, 2023 02:19

pullapprove bot added the review - pending label Apr 20, 2023

joonhaengHeo and others added 2 commits April 20, 2023 11:34

remove additional code

e32dbb0

Merge branch 'master' into implement_android_generic_im

e9b776e

yunhanw-google reviewed Apr 20, 2023

View reviewed changes

...id/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/SensorClientFragment.kt Outdated Show resolved Hide resolved

yunhanw-google approved these changes Apr 20, 2023

View reviewed changes

yunhanw-google reviewed Apr 20, 2023

View reviewed changes

src/controller/java/BUILD.gn Show resolved Hide resolved

restore test code

b14f5bf

yunhanw-google requested a review from andy31415 May 19, 2023 17:45

andy31415 added the fast track label May 19, 2023

andy31415 merged commit b51219b into project-chip:master May 19, 2023

joonhaengHeo added a commit to joonhaengHeo/connectedhomeip that referenced this pull request May 22, 2023

Revert "Revert "[Android] Implement using generic IM(invoke,read,writ…

28b3fcd

…e,subscribe) APIs (project-chip#25956)" (project-chip#26704)" This reverts commit bfa0580.

joonhaengHeo mentioned this pull request May 22, 2023

[Android] Implement using generic IM(invoke,read,write,subscribe) APIs - reupload #26710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Implement using generic IM(invoke,read,write,subscribe) APIs #25956

[Android] Implement using generic IM(invoke,read,write,subscribe) APIs #25956

joonhaengHeo commented Apr 4, 2023 •

edited

Loading

github-actions bot commented Apr 4, 2023

andy31415 commented Apr 4, 2023

joonhaengHeo commented Apr 5, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 7, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 20, 2023

bzbarsky-apple commented May 19, 2023

[Android] Implement using generic IM(invoke,read,write,subscribe) APIs #25956

[Android] Implement using generic IM(invoke,read,write,subscribe) APIs #25956

Conversation

joonhaengHeo commented Apr 4, 2023 • edited Loading

github-actions bot commented Apr 4, 2023

andy31415 commented Apr 4, 2023

joonhaengHeo commented Apr 5, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 7, 2023

github-actions bot commented Apr 17, 2023

github-actions bot commented Apr 20, 2023

bzbarsky-apple commented May 19, 2023

joonhaengHeo commented Apr 4, 2023 •

edited

Loading