-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use version from zap.json to download zap #25791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
March 23, 2023 00:09
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 23, 2023 00:09
lebauce
changed the title
Fix zap downloading from source
Use version from zap.json to download zap
Mar 23, 2023
lebauce
force-pushed
the
zap-download-source
branch
from
March 23, 2023 00:11
bdf0839
to
59ca7a6
Compare
lebauce
force-pushed
the
zap-download-source
branch
from
March 23, 2023 00:19
59ca7a6
to
d83749f
Compare
PR #25791: Size comparison from e214d1e to d83749f Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Mar 23, 2023
bzbarsky-apple
approved these changes
Mar 23, 2023
lebauce
force-pushed
the
zap-download-source
branch
from
March 24, 2023 01:05
d83749f
to
35e8a46
Compare
lebauce
force-pushed
the
zap-download-source
branch
from
March 24, 2023 01:05
35e8a46
to
538bb19
Compare
PR #25791: Size comparison from a4a407b to 538bb19 Increases (7 builds for cc13x2_26x2, psoc6, qpg, telink)
Decreases (9 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zap version was retrieved from a Dockerfile that doesn't exist any more.
Use zap.json instead to get it.