Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer/long detection for codegen #25757

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

andy31415
Copy link
Contributor

ZAP asJavaType considers every 32-bit integer to be Long and smaller to be Integer (unclear why since java integers are supposed to be 32 bit, however this is what the code does).

Found two bugs in our codegen:

  • 24-bit integers were not considered (check for >= 4 only matched 32-bit but not 24-bit, where as zap matches 24-bit too)
  • matching was not done for bitmaps and enums (zap code did match these)

@github-actions
Copy link

PR #25757: Size comparison from 8425d28 to 8b3fcf3

Decreases (1 build for cc32xx)
platform target config section 8425d28 8b3fcf3 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20248011 20248010 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 8425d28 8b3fcf3 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645601 645601 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930289 930289 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300316 300316 0 0.0
.debug_info 20248011 20248010 -1 -0.0
.debug_line 2661469 2661469 0 0.0
.debug_loc 2805592 2805592 0 0.0
.debug_ranges 283208 283208 0 0.0
.debug_str 3027174 3027174 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380421 380421 0 0.0
.symtab 257408 257408 0 0.0
.text 537488 537488 0 0.0

@andy31415 andy31415 merged commit f5e32c1 into project-chip:master Mar 21, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Fix integer/long detection for codegen

* Remove duplicate import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants