Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "reportable":0 from Matter .zap files, again. #25683

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

These should never be happening, since all Matter attributes are "reportable" in this sense (modulo the C quality, but that's not what "reportable" really means). If things are not reportable in a .zap, that indicates that someone either hand-edited the .zap in a weird way, or did things in the ZAP UI that they should not have done.

These should never be happening, since all Matter attributes are "reportable" in
this sense (modulo the C quality, but that's not what "reportable" really
means).  If things are not reportable in a .zap, that indicates that someone
either hand-edited the .zap in a weird way, or did things in the ZAP UI that
they should not have done.
@github-actions
Copy link

PR #25683: Size comparison from fa2e709 to 6bdf612

Increases (1 build for cc32xx)
platform target config section fa2e709 6bdf612 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245969 20245970 1 0.0
Full report (1 build for cc32xx)
platform target config section fa2e709 6bdf612 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245970 1 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804911 2804911 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit a1f3d5f into project-chip:master Mar 14, 2023
@bzbarsky-apple bzbarsky-apple deleted the make-all-reportable branch March 14, 2023 21:29
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
)

These should never be happening, since all Matter attributes are "reportable" in
this sense (modulo the C quality, but that's not what "reportable" really
means).  If things are not reportable in a .zap, that indicates that someone
either hand-edited the .zap in a weird way, or did things in the ZAP UI that
they should not have done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants