Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce priority of factory reset task #25598

Conversation

mlepage-google
Copy link
Contributor

Since the task priorities were adjusted for #24099 (and maybe even before?) the factory reset RPC would time out, breaking any test which relies on the RPC successfully completing.

This is because the reset is happening immediately, before whatever is handling the RPC can complete.

Reducing the FreeRTOS task priority just before the reset "fixes" it. (Maybe there's a better fix?)

Tested on Mighty Gecko SiLabs board.

Since the task priorities were adjusted for project-chip#24099
(and maybe even before?) the factory reset RPC would
time out, breaking any test which relies on the RPC
successfully completing.

This is because the reset is happening immediately,
before whatever is handling the RPC can complete.

Reducing the FreeRTOS task priority just before the
reset "fixes" it. (Maybe there's a better fix?)

Tested on Mighty Gecko SiLabs board.
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25598: Size comparison from 99cbba0 to a62713a

Decreases (1 build for cc32xx)
platform target config section 99cbba0 a62713a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20268460 20268459 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 99cbba0 a62713a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300048 300048 0 0.0
.debug_info 20268460 20268459 -1 -0.0
.debug_line 2659917 2659917 0 0.0
.debug_loc 2802993 2802993 0 0.0
.debug_ranges 282936 282936 0 0.0
.debug_str 3023875 3023875 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536412 536412 0 0.0

@mlepage-google mlepage-google merged commit 7b1c641 into project-chip:master Mar 10, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Since the task priorities were adjusted for project-chip#24099
(and maybe even before?) the factory reset RPC would
time out, breaking any test which relies on the RPC
successfully completing.

This is because the reset is happening immediately,
before whatever is handling the RPC can complete.

Reducing the FreeRTOS task priority just before the
reset "fixes" it. (Maybe there's a better fix?)

Tested on Mighty Gecko SiLabs board.
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
Since the task priorities were adjusted for project-chip#24099
(and maybe even before?) the factory reset RPC would
time out, breaking any test which relies on the RPC
successfully completing.

This is because the reset is happening immediately,
before whatever is handling the RPC can complete.

Reducing the FreeRTOS task priority just before the
reset "fixes" it. (Maybe there's a better fix?)

Tested on Mighty Gecko SiLabs board.
@mlepage-google mlepage-google deleted the rpc-factory-reset-task-priority branch April 5, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants