-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce priority of factory reset task #25598
Merged
mlepage-google
merged 1 commit into
project-chip:master
from
mlepage-google:rpc-factory-reset-task-priority
Mar 10, 2023
Merged
Reduce priority of factory reset task #25598
mlepage-google
merged 1 commit into
project-chip:master
from
mlepage-google:rpc-factory-reset-task-priority
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the task priorities were adjusted for project-chip#24099 (and maybe even before?) the factory reset RPC would time out, breaking any test which relies on the RPC successfully completing. This is because the reset is happening immediately, before whatever is handling the RPC can complete. Reducing the FreeRTOS task priority just before the reset "fixes" it. (Maybe there's a better fix?) Tested on Mighty Gecko SiLabs board.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
March 9, 2023 22:22
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
March 9, 2023 22:23
PR #25598: Size comparison from 99cbba0 to a62713a Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
msandstedt
approved these changes
Mar 10, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Since the task priorities were adjusted for project-chip#24099 (and maybe even before?) the factory reset RPC would time out, breaking any test which relies on the RPC successfully completing. This is because the reset is happening immediately, before whatever is handling the RPC can complete. Reducing the FreeRTOS task priority just before the reset "fixes" it. (Maybe there's a better fix?) Tested on Mighty Gecko SiLabs board.
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
Since the task priorities were adjusted for project-chip#24099 (and maybe even before?) the factory reset RPC would time out, breaking any test which relies on the RPC successfully completing. This is because the reset is happening immediately, before whatever is handling the RPC can complete. Reducing the FreeRTOS task priority just before the reset "fixes" it. (Maybe there's a better fix?) Tested on Mighty Gecko SiLabs board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the task priorities were adjusted for #24099 (and maybe even before?) the factory reset RPC would time out, breaking any test which relies on the RPC successfully completing.
This is because the reset is happening immediately, before whatever is handling the RPC can complete.
Reducing the FreeRTOS task priority just before the reset "fixes" it. (Maybe there's a better fix?)
Tested on Mighty Gecko SiLabs board.