Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscription liveness timeout computation to include MRP backoff. #25593

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix subscription liveness timeout computation to include MRP backoff. #25593

merged 1 commit into from
Mar 9, 2023

Commits on Mar 9, 2023

  1. Fix subscription liveness timeout computation to include MRP backoff. 

    Right now the amount of time we allow for receiving a subscription report, after
the max-interval has elapsed, is computed by just multiplying our active
liveness timeout by the number of MRP retries.  For a typical always-active
client (hence 300ms active interval) that means 1500ms.

But an actual sender would do backoff in between the MRP messages, so would not
actually give up within 1500ms.  We should be taking that backoff into account
when computing the time we allow to receive the message.
    @bzbarsky-apple
    bzbarsky-apple committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c058f43 View commit details
    Browse the repository at this point in the history