Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android/tv-casting-app: Adding defensive checks in Discovery/record parsing #25464

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Android/tv-casting-app: Adding defensive checks in Discovery/record parsing #25464

merged 2 commits into from
Mar 7, 2023

Conversation

sharadb-amazon
Copy link
Contributor

Fixes #25463

Change summary

  • Added defensive check in logic to parse TXT records in DiscoveredNodeData.
  • Added defensive checks to see if the multicastLock isHeld() before release()ing it.
  • Stopped trying to stopDiscovery if it is not ongoing in the first place.

Testing

Tested with the Android tv-casting-app running against the Linux tv-app

sharadb-amazon and others added 2 commits March 3, 2023 09:20
@sharadb-amazon
Checking if multicastLock isHeld before trying to release it, avoidin…
02af39d 
…g stopServiceDiscovery call if discovery failed to start
@sharadb-amazon
Android tv-casting-app: Adding defensive checks in DiscoveredNodeData…
90bdc18 
… constructor (#108)

* Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor

* Adding more defensive checks / exception handling
@sharadb-amazon sharadb-amazon added tv-casting examples bug Something isn't working labels Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

PR #25464: Size comparison from 0573c94 to 90bdc18

Increases (1 build for cc32xx)
platform target config section 0573c94 90bdc18 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262928 20262929 1 0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 0573c94 90bdc18 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262928 20262929 1 0.0
.debug_line 2657820 2657820 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467384 2467384 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430028 1430028 0 0.0

@chrisdecenzo chrisdecenzo merged commit bfd9b2e into project-chip:master Mar 7, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@sharadb-amazon
Android/tv-casting-app: Adding defensive checks in Discovery/record p…
1725dc5 
…arsing (project-chip#25464)

* Checking if multicastLock isHeld before trying to release it, avoiding stopServiceDiscovery call if discovery failed to start

* Android tv-casting-app: Adding defensive checks in DiscoveredNodeData constructor (project-chip#108)

* Android tv-casting-app: Adding defensive null checks in DiscoveredNodeData constructor

* Adding more defensive checks / exception handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@hawk248 hawk248 Awaiting requested review from hawk248

Assignees
No one assigned
Labels
bug Something isn't working examples review - approved tv-casting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Android/tv-casting-app: NPEs
4 participants
@sharadb-amazon @hawk248 @chrisdecenzo @cliffamzn