Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the PathsFinder module in scripts/tests/run_test_suite.py instead… #25368

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Use the PathsFinder module in scripts/tests/run_test_suite.py instead… #25368

merged 1 commit into from
Feb 28, 2023

Conversation

vivien-apple
Copy link
Contributor

… of having duplicated code

Problem

Both scripts/tests/yaml/runner.py and scripts/tests/run_test_suites.py are using a cache for finding binary files.

This PR removes the version in scripts/tests/run_test_suites.py which is basically the same as the code in PathsFinder except that it does not offer some code to view/manipulate the cache.

@vivien-apple vivien-apple self-assigned this Feb 28, 2023
@vivien-apple vivien-apple marked this pull request as ready for review February 28, 2023 11:35
@github-actions
Copy link

PR #25368: Size comparison from de6f9a1 to 038482f

Increases (1 build for cc32xx)
platform target config section de6f9a1 038482f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20261983 20261985 2 0.0
Full report (1 build for cc32xx)
platform target config section de6f9a1 038482f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643073 643073 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930155 930155 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299824 299824 0 0.0
.debug_info 20261983 20261985 2 0.0
.debug_line 2657104 2657104 0 0.0
.debug_loc 2799620 2799620 0 0.0
.debug_ranges 282184 282184 0 0.0
.debug_str 3023185 3023185 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105889 105889 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256240 256240 0 0.0
.text 535060 535060 0 0.0

tehampson
tehampson approved these changes Feb 28, 2023
View reviewed changes
scripts/tests/run_test_suite.py Show resolved Hide resolved
@vivien-apple vivien-apple mentioned this pull request Feb 28, 2023
Open
@vivien-apple vivien-apple force-pushed the YamlTests_UsePathsFinderInRunTestSuite branch from 038482f to 5dede5a Compare February 28, 2023 17:28
@github-actions
Copy link

PR #25368: Size comparison from d6a783e to 5dede5a

Increases (1 build for cc32xx)
platform target config section d6a783e 5dede5a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20262891 20262892 1 0.0
Full report (1 build for cc32xx)
platform target config section d6a783e 5dede5a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262891 20262892 1 0.0
.debug_line 2657205 2657205 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023623 3023623 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378494 378494 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0

@pullapprove pullapprove bot requested a review from cliffamzn February 28, 2023 19:21
@andy31415 andy31415 merged commit 761aaf5 into project-chip:master Feb 28, 2023
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge branch 'bl702l_matter' of github.com:bouffalolab/connectedhomei…
a738160 
…p-1 into bl702l_matter

* 'bl702l_matter' of github.com:bouffalolab/connectedhomeip-1: (446 commits)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  Set thread sleep and yield backends for rpc (project-chip#25350)
  [config-data] Remove some enums that just don't generate anything (project-chip#25370)
  [Tizen] CI workflow for running QEMU-based tests (project-chip#24871)
  ...
shchen-Lab added a commit to bouffalolab/connectedhomeip-1 that referenced this pull request Mar 1, 2023
@shchen-Lab
Merge remote-tracking branch 'official/master' into test
7433911 
* official/master: (449 commits)
  tv-casting-app: Updating the context we pass to FindOrEstablishSession
  Changing caching logic to match video players using hostname before other attributes
  Enable -Wconversion tree-wide on darwin. (project-chip#25376)
  [Python] Add Python commissioning flow (project-chip#25119)
  Add to flake8 in workflow and fix python files (project-chip#25280)
  Align Time Format Localization cluster XML to spec changes. (project-chip#25289)
  Use the PathsFinder module in scripts/tests/run_test_suite.py instead of having duplicated code (project-chip#25368)
  Add a continuous browse for Matter operational advertisements on Darwin. (project-chip#25317)
  Chef doorlock sample update (project-chip#24118)
  Fix implementation of OnChipScanComplete and OnScanComplete - second PR (project-chip#24873)
  Add to flake8 in workflow and fix python files (project-chip#25279)
  Make PASE setup a bit more robust if multiple clients race. (project-chip#25352)
  Add dependent lib kotlin-stdlib for kotlin version of java-matter-controller (project-chip#25358)
  [python tests] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25312)
  Add to flake8 in workflow and fix python files (project-chip#25283)
  Add a way to read a concrete attribute path from AttributePathIB::Parser. (project-chip#25293)
  Make sure various tests in TestReadInteraction are not no-ops. (project-chip#25298)
  [Android] Add isUrgent option in Android (project-chip#25301)
  [NXP] Add to flake8 in workflow and fix python files (part project-chip#25193) (project-chip#25305)
  [placeholder] Allow applications can specify which additional sources to build (project-chip#25346)
  ...
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Mar 10, 2023
@bzbarsky-apple
Fix run_testsuite.py so it works if not all of the apps are specified.
63c0612 
When running only a subset of tests (e.g. only DL_* tests), not all apps are
needed for the tests to run.

This used to work because we used a fake "NOT_FOUND_IN_OUTPUT_" path for the
missing apps, which was a string so the string manipulation on it worked, and
the output was never used.

But after project-chip#25368 we end up
with None where we expect a string, and the script dies.

The fix is just to skip string manipulation on the path of apps that have None
as a path.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 10, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Mar 10, 2023
@bzbarsky-apple
Fix run_testsuite.py so it works if not all of the apps are specified.
9d928d9 
When running only a subset of tests (e.g. only DL_* tests), not all apps are
needed for the tests to run.

This used to work because we used a fake "NOT_FOUND_IN_OUTPUT_" path for the
missing apps, which was a string so the string manipulation on it worked, and
the output was never used.

But after project-chip#25368 we end up
with None where we expect a string, and the script dies.

The fix is just to skip string manipulation on the path of apps that have None
as a path.
bzbarsky-apple added a commit that referenced this pull request Mar 10, 2023
@bzbarsky-apple
Fix run_testsuite.py so it works if not all of the apps are specified. (
f1f69c0 
#25600)

When running only a subset of tests (e.g. only DL_* tests), not all apps are
needed for the tests to run.

This used to work because we used a fake "NOT_FOUND_IN_OUTPUT_" path for the
missing apps, which was a string so the string manipulation on it worked, and
the output was never used.

But after #25368 we end up
with None where we expect a string, and the script dies.

The fix is just to skip string manipulation on the path of apps that have None
as a path.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this pull request Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Fix run_testsuite.py so it works if not all of the apps are specified…
2776d49 
…. (#25600)

When running only a subset of tests (e.g. only DL_* tests), not all apps are
needed for the tests to run.

This used to work because we used a fake "NOT_FOUND_IN_OUTPUT_" path for the
missing apps, which was a string so the string manipulation on it worked, and
the output was never used.

But after project-chip/connectedhomeip#25368 we end up
with None where we expect a string, and the script dies.

The fix is just to skip string manipulation on the path of apps that have None
as a path.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
Use the PathsFinder module in scripts/tests/run_test_suite.py instead…
03756d4 
… of having duplicated code (project-chip#25368)
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Fix run_testsuite.py so it works if not all of the apps are specified. (
2044db0 
project-chip#25600)

When running only a subset of tests (e.g. only DL_* tests), not all apps are
needed for the tests to run.

This used to work because we used a fake "NOT_FOUND_IN_OUTPUT_" path for the
missing apps, which was a string so the string manipulation on it worked, and
the output was never used.

But after project-chip#25368 we end up
with None where we expect a string, and the script dies.

The fix is just to skip string manipulation on the path of apps that have None
as a path.
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@bzbarsky-apple @mwswartwout
Fix run_testsuite.py so it works if not all of the apps are specified. (
e3da948 
project-chip#25600)

When running only a subset of tests (e.g. only DL_* tests), not all apps are
needed for the tests to run.

This used to work because we used a fake "NOT_FOUND_IN_OUTPUT_" path for the
missing apps, which was a string so the string manipulation on it worked, and
the output was never used.

But after project-chip#25368 we end up
with None where we expect a string, and the script dies.

The fix is just to skip string manipulation on the path of apps that have None
as a path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehampson tehampson tehampson approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

Assignees

@vivien-apple vivien-apple

Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @tehampson @bzbarsky-apple @andy31415