Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused BLE defines. #25282

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Nothing was checking the values of CHIP_DEVICE_LAYER_BLE_CONN_CFG_TAG or CHIP_DEVICE_LAYER_BLE_OBSERVER_PRIORITY.

Nothing was checking the values of CHIP_DEVICE_LAYER_BLE_CONN_CFG_TAG or CHIP_DEVICE_LAYER_BLE_OBSERVER_PRIORITY.
@github-actions
Copy link

PR #25282: Size comparison from b236bfb to 520ff32

Increases (1 build for cc32xx)
platform target config section b236bfb 520ff32 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20253400 20253401 1 0.0
Full report (1 build for cc32xx)
platform target config section b236bfb 520ff32 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299776 299776 0 0.0
.debug_info 20253400 20253401 1 0.0
.debug_line 2655882 2655882 0 0.0
.debug_loc 2797015 2797015 0 0.0
.debug_ranges 281760 281760 0 0.0
.debug_str 3018765 3018765 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@andy31415 andy31415 merged commit d365f27 into project-chip:master Feb 24, 2023
@bzbarsky-apple bzbarsky-apple deleted the remove-unused-defines branch February 24, 2023 14:58
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Nothing was checking the values of CHIP_DEVICE_LAYER_BLE_CONN_CFG_TAG or CHIP_DEVICE_LAYER_BLE_OBSERVER_PRIORITY.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants