Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Power Source cluster XML to spec changes. #25233

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Align Power Source cluster XML to spec changes. #25233

merged 3 commits into from
Feb 23, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 21, 2023 •
edited
Loading

REVIEW NOTE: Only the first changeset is written by hand.

Spec changes happened in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6211.

Fixes #25181

@github-actions
Copy link

PR #25233: Size comparison from 30188f5 to bfb8caa

Increases (1 build for cc32xx)
platform target config section 30188f5 bfb8caa change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3017876 3018642 766 0.0
Full report (1 build for cc32xx)
platform target config section 30188f5 bfb8caa change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254059 20254059 0 0.0
.debug_line 2655143 2655143 0 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017876 3018642 766 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377610 377610 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@github-actions
Copy link

PR #25233: Size comparison from 5847d93 to 5ee1be6

Increases (1 build for cc32xx)
platform target config section 5847d93 5ee1be6 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_aranges 87272 87304 32 0.0
.debug_frame 299764 299860 96 0.0
.debug_info 20250790 20254401 3611 0.0
.debug_line 2655140 2655440 300 0.0
.debug_loc 2795463 2795952 489 0.0
.debug_ranges 281592 281624 32 0.0
.debug_str 3018049 3022743 4694 0.2
Full report (1 build for cc32xx)
platform target config section 5847d93 5ee1be6 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642569 642569 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930138 930138 0 0.0
.debug_aranges 87272 87304 32 0.0
.debug_frame 299764 299860 96 0.0
.debug_info 20250790 20254401 3611 0.0
.debug_line 2655140 2655440 300 0.0
.debug_loc 2795463 2795952 489 0.0
.debug_ranges 281592 281624 32 0.0
.debug_str 3018049 3022743 4694 0.2
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377761 377761 0 0.0
.symtab 256256 256256 0 0.0
.text 534628 534628 0 0.0

@github-actions
Copy link

PR #25233: Size comparison from b236bfb to f892e1b

Increases (1 build for cc32xx)
platform target config section b236bfb f892e1b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_aranges 87272 87304 32 0.0
.debug_frame 299776 299872 96 0.0
.debug_info 20253400 20257010 3610 0.0
.debug_line 2655882 2656183 301 0.0
.debug_loc 2797015 2797535 520 0.0
.debug_ranges 281760 281792 32 0.0
.debug_str 3018765 3023459 4694 0.2
Full report (1 build for cc32xx)
platform target config section b236bfb f892e1b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87272 87304 32 0.0
.debug_frame 299776 299872 96 0.0
.debug_info 20253400 20257010 3610 0.0
.debug_line 2655882 2656183 301 0.0
.debug_loc 2797015 2797535 520 0.0
.debug_ranges 281760 281792 32 0.0
.debug_str 3018765 3023459 4694 0.2
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@github-actions
Copy link

PR #25233: Size comparison from 84c77b6 to 1bdb1e5

Increases (1 build for cc32xx)
platform target config section 84c77b6 1bdb1e5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_aranges 87272 87304 32 0.0
.debug_frame 299776 299872 96 0.0
.debug_info 20253400 20257011 3611 0.0
.debug_line 2655882 2656183 301 0.0
.debug_loc 2797015 2797535 520 0.0
.debug_ranges 281760 281792 32 0.0
.debug_str 3018765 3023459 4694 0.2
Full report (3 builds for cc32xx, qpg)
platform target config section 84c77b6 1bdb1e5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87272 87304 32 0.0
.debug_frame 299776 299872 96 0.0
.debug_info 20253400 20257011 3611 0.0
.debug_line 2655882 2656183 301 0.0
.debug_loc 2797015 2797535 520 0.0
.debug_ranges 281760 281792 32 0.0
.debug_str 3018765 3023459 4694 0.2
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151340 1151340 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598436 598436 0 0.0
lock-app qpg6105+debug (read/write) 1118540 1118540 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565640 565640 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 7775bec into project-chip:master Feb 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the rename-power-source branch February 23, 2023 21:50
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Align Power Source cluster XML to spec changes. (project-chip#25233)
2528b1c 
* Align Power Source cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6211.

Fixes project-chip#25181

* Auto-update ZAP files.

* Regenerate generated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

Assignees
No one assigned
Labels
app controller darwin examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XML] Update Power Source Cluster XML to match updated spec
3 participants
@bzbarsky-apple @andy31415 @jmartinez-silabs