Variable "_custom_impl_clusters" unused before it went out of scope #25177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
msandstedt,
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs and
vivien-apple
pullapprove
bot
requested review from
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #25177: Size comparison from 5b358b2 to 213c0b0 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
reviewed
Feb 21, 2023
andy31415
approved these changes
Feb 22, 2023
cliffamzn
approved these changes
Feb 22, 2023
When generating data model with no clusters then a build error is
generated due to the "_custom_impl_clusters" variable being unused
before it went out of scope.
```
ERROR at //src/app/chip_data_model.gni:192:29: Assignment had no effect.
_custom_impl_clusters = []
^
You set the variable "_custom_impl_clusters" here and it was unused
before it went out of scope.
```
To prevent the issue, "_custom_impl_clusters" can be marked as not
needed.
|
PR #25177: Size comparison from 015f11c to c948a83 Full report (1 build for cc32xx)
|
chrisdecenzo
approved these changes
Feb 23, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#25177) When generating data model with no clusters then a build error is generated due to the "_custom_impl_clusters" variable being unused before it went out of scope. ``` ERROR at //src/app/chip_data_model.gni:192:29: Assignment had no effect. _custom_impl_clusters = [] ^ You set the variable "_custom_impl_clusters" here and it was unused before it went out of scope. ``` To prevent the issue, "_custom_impl_clusters" can be marked as not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating data model with no clusters then a build error is generated due to the "_custom_impl_clusters" variable being unused before it went out of scope.
To prevent the issue, "_custom_impl_clusters" can be marked as not needed.