Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] ESP-IDF v5.0 support in reamining apps #24983

Merged
merged 6 commits into from
Feb 13, 2023
Merged

[ESP32] ESP-IDF v5.0 support in reamining apps #24983

merged 6 commits into from
Feb 13, 2023

Conversation

shubhamdp
Copy link
Contributor

Problem

Fixes #24576

Change Overview

Added support for esp-idf v5.0 in ota-requestor-app, ota-provider-app, temperature-measurement-app, lock-app, and chef-app.

In a nutshell:

  • Fixed few format specifier
  • Changed ErrorStr to err.Format()
  • Added components to required list. In v4.4.4 these made it to list somehow through some other component's global requirement list but, those are not made private and hence needed to be added explicitly.

Testing

Successfully compiled above apps for esp32c3 on idf v5.0 and v4.4.3

@github-actions
Copy link

PR #24983: Size comparison from 5ad70f6 to 6da772a

Increases (1 build for cc32xx)
platform target config section 5ad70f6 6da772a change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194394 20194395 1 0.0
Full report (1 build for cc32xx)
platform target config section 5ad70f6 6da772a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194394 20194395 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Feb 10, 2023
View reviewed changes
examples/lock-app/esp32/main/DeviceCallbacks.cpp Outdated Show resolved Hide resolved
examples/lock-app/esp32/main/DeviceCallbacks.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #24983: Size comparison from 5ad70f6 to de4487f

Increases (1 build for cc32xx)
platform target config section 5ad70f6 de4487f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194394 20194444 50 0.0
.debug_line 2649797 2649825 28 0.0
.debug_loc 2785922 2785969 47 0.0
Decreases (1 build for cc32xx)
platform target config section 5ad70f6 de4487f change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_ranges 280720 280696 -24 -0.0
Full report (1 build for cc32xx)
platform target config section 5ad70f6 de4487f change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194394 20194444 50 0.0
.debug_line 2649797 2649825 28 0.0
.debug_loc 2785922 2785969 47 0.0
.debug_ranges 280720 280696 -24 -0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 660dc84 into project-chip:master Feb 13, 2023
@dhrishi dhrishi mentioned this pull request Mar 21, 2023
Closed
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@shubhamdp
[ESP32] ESP-IDF v5.0 support in reamining apps (project-chip#24983)
aef732c 
* [ESP32] ota-requestor-app: changes to support idf v5.0

* [ESP32] ota-provider-app: changes to support idf v5.0

* [ESP32] temperature-measurement-app: changes to support idf v5.0

* [ESP32] lock-app: changes to support idf v5.0

* [ESP32] chef-app: changes to support idf v5.0

* Fix specifiers for endpoint/cluster/attribute ids
@shubhamdp shubhamdp deleted the esp32_apps1_idf_v5.0 branch July 28, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@dhrishi dhrishi Awaiting requested review from dhrishi

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] [ESP32] Support esp-idf v5.0 release
4 participants
@shubhamdp @andy31415 @dhrishi @bzbarsky-apple