Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] Small miscellaneous fixes: #24956

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

jmartinez-silabs
Copy link
Member

Silabs build version

  • exclude the tag from the build version string as it makes quite a long string and the last tag is not really relevant to the current state
  • move the silabs_config wich contains the version str to the silabs common source_set instead of calling it in each example.

Silabs FactoryDataProvider.py

  • fix key mismatch in the factoryProvider script for the VendorName and Productname.
  • Correctly rename the argument rotating_id to unique_id ¯_(ツ)_/¯

…ove the silabs_config wich contains the version str to the silabs common source_set instead of calling it in each example.

fix key mismatch in the factoryProvider script for the VendorName and Productname. Rename argument rotating_id to unique_id
@github-actions
Copy link

PR #24956: Size comparison from e2e6095 to 2eb587b

Increases (2 builds for cc32xx, nrfconnect)
platform target config section e2e6095 2eb587b change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194395 20194396 1 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 764272 764276 4 0.0
Full report (5 builds for cc32xx, mbed, nrfconnect)
platform target config section e2e6095 2eb587b change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194395 20194396 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464576 2464576 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427220 1427220 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162364 1162364 0 0.0
bss 143531 143531 0 0.0
rodata 134376 134376 0 0.0
text 804572 804572 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108392 1108392 0 0.0
bss 142687 142687 0 0.0
rodata 111364 111364 0 0.0
text 774564 774564 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367600 1367600 0 0.0
bss 105990 105990 0 0.0
rodata 211808 211808 0 0.0
text 764272 764276 4 0.0

@andy31415 andy31415 merged commit a5b80df into project-chip:master Feb 10, 2023
@jmartinez-silabs jmartinez-silabs deleted the misc_fix branch February 10, 2023 13:57
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Miscellaneous fixes: exclude the tag from the build version string, move the silabs_config wich contains the version str to the silabs common source_set instead of calling it in each example.
fix key mismatch in the factoryProvider script for the VendorName and Productname. Rename argument rotating_id to unique_id

* Restyled by autopep8

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants