Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some types from silabs/types-silabs.xml to draft/types #24899

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Move some types from silabs/types-silabs.xml to draft/types #24899

merged 2 commits into from
Feb 7, 2023

Conversation

vivien-apple
Copy link
Contributor

Problem

This moves more types out of silabs/types-silabs.xml to the draft folder with the additional removal of some types where I have not found their equivalent mentioned in the spec:

  • ShadeClosureStatus: Belongs to the Shade Configuration Cluster (0x0100) for the Status attribute
  • MainsAlarmsMask: Belongs to the Power Configuration Cluster (0x0001) for the MainsAlarmMask attribute
  • BatteryAlarmsMask: Belongs to the Power Configuration Cluster (0x0001) for the BatteryAlarmMask attribute
  • BatterySize: Belongs to the Power Configuration Cluster (0x0001) for the BatterySize attribute
  • DeviceTempAlarmMask: Belongs to the Device Temperature Configuration cluster (0x0002) for the DeviceTempAlarmMask attribute
  • TimeStatusMasl: Belongs to the Time cluster (0x000a) for the TimeStatus attribute. ZCL only.
    Remove things that belongs to the IAS WD Cluster (0x502):
    • WarningMode
    • WarningStobe
    • SquawkMode
    • SquawkStobe
    • SquawkLevel
  • AmiRegistrationState since this is for Advanced Metering Infrastructure.

@vivien-apple vivien-apple self-assigned this Feb 7, 2023
@vivien-apple vivien-apple changed the title Types silabs remove more types Move some types from silabs/types-silabs.xml to draft/types Feb 7, 2023
@github-actions github-actions bot added the app label Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023 •
edited
Loading

PR #24899: Size comparison from a894041 to ed35ebb

Increases (6 builds for bl602, bl702, cc13x2_26x2, k32w, nrfconnect)
platform target config section a894041 ed35ebb change % change
bl602 lighting-app bl602+rpc .text 1053772 1053774 2 0.0
bl702 lighting-app bl702 (read/write) 1184155 1184171 16 0.0
.debug_info 40224843 40224845 2 0.0
.text 952208 952212 4 0.0
bl702+rpc .debug_info 44623675 44623676 1 0.0
.text 1029404 1029406 2 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674451 674459 8 0.0
.text 597648 597656 8 0.0
k32w contact k32w0+release (read/write) 659848 659864 16 0.0
.text 562064 562080 16 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 774420 774424 4 0.0
Decreases (4 builds for cc13x2_26x2, cc32xx, nrfconnect, psoc6)
platform target config section a894041 ed35ebb change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 174076 174068 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19915393 19915392 -1 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 804428 804424 -4 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 2272852 22728527 -1 -0.0
Full report (28 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, mbed, nrfconnect, psoc6, qpg)
platform target config section a894041 ed35ebb change % change
bl602 lighting-app bl602 (read/write) 1346094 1346094 0 0.0
.bss 94794 94794 0 0.0
.data 9736 9736 0 0.0
.text 1023096 1023096 0 0.0
bl602+rpc (read/write) 1391286 1391286 0 0.0
.bss 102842 102842 0 0.0
.data 10128 10128 0 0.0
.text 1053772 1053774 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184155 1184171 16 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69905 69905 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550344 1550344 0 0.0
.debug_aranges 134176 134176 0 0.0
.debug_frame 491408 491408 0 0.0
.debug_info 40224843 40224845 2 0.0
.debug_line 5268117 5268117 0 0.0
.debug_loc 3401462 3401462 0 0.0
.debug_ranges 371816 371816 0 0.0
.debug_str 3535545 3535545 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106864 106864 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 572338 572338 0 0.0
.symtab 173376 173376 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952208 952212 4 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277055 1277055 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77953 77953 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698758 1698758 0 0.0
.debug_aranges 142408 142408 0 0.0
.debug_frame 519152 519152 0 0.0
.debug_info 44623675 44623676 1 0.0
.debug_line 5666824 5666824 0 0.0
.debug_loc 3598205 3598205 0 0.0
.debug_ranges 395584 395584 0 0.0
.debug_str 3938909 3938909 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121440 121440 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 633131 633131 0 0.0
.symtab 191792 191792 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1029404 1029406 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677343 677343 0 0.0
(read/write) 173840 173840 0 0.0
.bss 80876 80876 0 0.0
.data 3384 3384 0 0.0
.rodata 87527 87527 0 0.0
.text 589500 589500 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641351 641351 0 0.0
(read/write) 157568 157568 0 0.0
.bss 80068 80068 0 0.0
.data 3384 3384 0 0.0
.rodata 77479 77479 0 0.0
.text 563552 563552 0 0.0
lock-ftd LP_CC2652R7 (read only) 674451 674459 8 0.0
(read/write) 174076 174068 -8 -0.0
.bss 78308 78308 0 0.0
.data 3312 3312 0 0.0
.rodata 76323 76323 0 0.0
.text 597648 597656 8 0.0
lock-mtd LP_CC2652R7 (read only) 660979 660979 0 0.0
(read/write) 182812 182812 0 0.0
.bss 73572 73572 0 0.0
.data 3312 3312 0 0.0
.rodata 102899 102899 0 0.0
.text 557600 557600 0 0.0
pump-app LP_CC2652R7 (read only) 687439 687439 0 0.0
(read/write) 161824 161824 0 0.0
.bss 78276 78276 0 0.0
.data 3276 3276 0 0.0
.rodata 90535 90535 0 0.0
.text 596424 596424 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672847 672847 0 0.0
(read/write) 176528 176528 0 0.0
.bss 78388 78388 0 0.0
.data 3300 3300 0 0.0
.rodata 86615 86615 0 0.0
.text 585752 585752 0 0.0
shell LP_CC2652R7 (read only) 668590 668590 0 0.0
(read/write) 184664 184664 0 0.0
.bss 82948 82948 0 0.0
.data 3380 3380 0 0.0
.rodata 84262 84262 0 0.0
.text 584016 584016 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (read only) 639725 639725 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928401 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 299792 299792 0 0.0
.debug_info 19915393 19915392 -1 -0.0
.debug_line 2646819 2646819 0 0.0
.debug_loc 2781044 2781044 0 0.0
.debug_ranges 280656 280656 0 0.0
.debug_str 2978585 2978585 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105269 105269 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375623 375623 0 0.0
.symtab 255664 255664 0 0.0
.text 0 0 0 0.0
532332 532332 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584282 584282 0 0.0
.app_xip_area 461092 461092 0 0.0
.bss 65632 65632 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588174 588174 0 0.0
.app_xip_area 459688 459688 0 0.0
.bss 70920 70920 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549762 549762 0 0.0
.app_xip_area 432060 432060 0 0.0
.bss 60192 60192 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read/write) 659848 659864 16 0.0
.bss 76560 76560 0 0.0
.data 2112 2112 0 0.0
.text 562064 562080 16 0.0
light k32w0+release (read/write) 671980 671980 0 0.0
.bss 74344 74344 0 0.0
.data 2064 2064 0 0.0
.text 592844 592844 0 0.0
lock k32w0+release (read/write) 631388 631388 0 0.0
.bss 75112 75112 0 0.0
.data 2084 2084 0 0.0
.text 551464 551464 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464072 2464072 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1426716 1426716 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161400 1161400 0 0.0
bss 143531 143531 0 0.0
rodata 133556 133556 0 0.0
text 804428 804424 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366668 1366668 0 0.0
bss 105990 105990 0 0.0
rodata 210988 210988 0 0.0
text 764160 764160 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107584 1107584 0 0.0
bss 142687 142687 0 0.0
rodata 110700 110700 0 0.0
text 774420 774424 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840872 840872 0 0.0
(read/write) 1756516 1756516 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189800 189800 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251930 1251930 0 0.0
.debug_aranges 111392 111392 0 0.0
.debug_frame 373948 373948 0 0.0
.debug_info 27524519 27524519 0 0.0
.debug_line 3781069 3781069 0 0.0
.debug_loc 3676006 3676006 0 0.0
.debug_ranges 362456 362456 0 0.0
.debug_str 3486476 3486476 0 0.0
.heap 840872 840872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 578105 578105 0 0.0
.symtab 424864 424864 0 0.0
.text 1555656 1555656 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841688 841688 0 0.0
(read/write) 1698276 1698276 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188992 188992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237601 1237601 0 0.0
.debug_aranges 110656 110656 0 0.0
.debug_frame 376392 376392 0 0.0
.debug_info 27080392 27080392 0 0.0
.debug_line 3789415 3789415 0 0.0
.debug_loc 3659736 3659736 0 0.0
.debug_ranges 360424 360424 0 0.0
.debug_str 3472229 3472229 0 0.0
.heap 841688 841688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 539313 539313 0 0.0
.symtab 410144 410144 0 0.0
.text 1498232 1498232 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850008 850008 0 0.0
(read/write) 1611724 1611724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180872 180872 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071935 1071935 0 0.0
.debug_aranges 102864 102864 0 0.0
.debug_frame 346828 346828 0 0.0
.debug_info 22502922 22502922 0 0.0
.debug_line 3341715 3341715 0 0.0
.debug_loc 3337868 3337868 0 0.0
.debug_ranges 319600 319600 0 0.0
.debug_str 3275475 3275475 0 0.0
.heap 850008 850008 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474518 474518 0 0.0
.symtab 377920 377920 0 0.0
.text 1420000 1420000 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845024 845024 0 0.0
(read/write) 1645940 1645940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185848 185848 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073639 1073639 0 0.0
.debug_aranges 103304 103304 0 0.0
.debug_frame 348768 348768 0 0.0
.debug_info 2272852 22728527 -1 -0.0
.debug_line 3343625 3343625 0 0.0
.debug_loc 3360628 3360628 0 0.0
.debug_ranges 321512 321512 0 0.0
.debug_str 3292701 3292701 0 0.0
.heap 845024 845024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477894 477894 0 0.0
.symtab 380080 380080 0 0.0
.text 1449232 1449232 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148244 1148244 0 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595344 595344 0 0.0
lock-app qpg6105+debug (read/write) 1116220 1116220 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563316 563316 0 0.0

@yufengwangca yufengwangca merged commit 4d6db27 into project-chip:master Feb 7, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
Move some types from silabs/types-silabs.xml to draft/types (project-…
136128b 
…chip#24899)

* Move some types from silabs/types-silabs.xml to draft/types

* Update generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

@vivien-apple vivien-apple

Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivien-apple @andy31415 @yufengwangca @bzbarsky-apple