-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[placeholder] Add logs to the json response in interactive server mode #24877
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Placeholder_AddLogInJsonResponseInInteractiveServerMode
Feb 7, 2023
Merged
[placeholder] Add logs to the json response in interactive server mode #24877
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Placeholder_AddLogInJsonResponseInInteractiveServerMode
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
February 6, 2023 17:26
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 6, 2023 17:26
PR #24877: Size comparison from df4ad95 to cda8606 Increases (7 builds for bl602, bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (10 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 6, 2023
andy31415
reviewed
Feb 6, 2023
andy31415
approved these changes
Feb 6, 2023
vivien-apple
force-pushed
the
Placeholder_AddLogInJsonResponseInInteractiveServerMode
branch
from
February 7, 2023 08:22
cda8606
to
2bade1f
Compare
PR #24877: Size comparison from 8d801e8 to 2bade1f Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds chip logs to the json response for placeholder apps. It makes it easier to debug and see the cause of the error when running a yaml test.