-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos related to the readEvent command in Test_TC_ACL_2_7.yaml, Test_TC_ACL_2_8.yaml and Test_TC_ACL_2_10.yaml #24780
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Typos_VariousTestsWithYamlTestsParser_attempt5
Feb 1, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 1, 2023 09:06
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yufengwangca
February 1, 2023 09:06
PR #24780: Size comparison from 8dc9323 to 13f3c61 Decreases (1 build for qpg)
Full report (6 builds for k32w, mbed, qpg)
|
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt5
branch
from
February 1, 2023 09:32
13f3c61
to
a3d04e1
Compare
PR #24780: Size comparison from 25df49b to a3d04e1 Increases (5 builds for cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (7 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Feb 1, 2023
…ml and Test_TC_ACL_2_8.yaml
vivien-apple
force-pushed
the
Typos_VariousTestsWithYamlTestsParser_attempt5
branch
from
February 1, 2023 13:53
a3d04e1
to
b20fa26
Compare
vivien-apple
changed the title
Fix some typos related to the readEvent command in Test_TC_ACL_2_7.yaml and Test_TC_ACL_2_8.yaml
Fix some typos related to the readEvent command in Test_TC_ACL_2_7.yaml, Test_TC_ACL_2_8.yaml and Test_TC_ACL_2_10.yaml
Feb 1, 2023
tehampson
approved these changes
Feb 1, 2023
PR #24780: Size comparison from 25df49b to b20fa26 Increases (5 builds for cc13x2_26x2, linux, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 1, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ml, Test_TC_ACL_2_8.yaml and Test_TC_ACL_2_10.yaml (project-chip#24780) * Fix some typos related to the readEvent command in Test_TC_ACL_2_7.yaml and Test_TC_ACL_2_8.yaml * Update generated tests content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
Test_TC_ACL_2_7.yaml
thevalue
field is not correctly written. It prevents codegen.In
Test_TC_ACL_2_8.yaml
andTest_TC_ACL_2_10.yaml
theprivilege
andauthMode
fields uses strings instead of numbers. This is fine for the codegen version, but does not fit well with the python runtime version.