[Silabs][SiWx917] Factory data provider for SiWx917 #24747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-silabs
force-pushed
the
feature/siwx917_factory_data
branch
from
8a0f203 to
fd28ca4
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple and
lazarkov
|
PR #24747: Size comparison from 210ae33 to fd28ca4 Increases (4 builds for bl602, esp32, psoc6)
Decreases (5 builds for nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Feb 1, 2023
|
PR #24747: Size comparison from 36d2d4d to 03511e0 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
PR #24747: Size comparison from 36d2d4d to 7b31294 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
chirag-silabs
force-pushed
the
feature/siwx917_factory_data
branch
from
7b31294 to
ee4b95d
Compare
|
PR #24747: Size comparison from 04adc52 to 832132a Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
bzbarsky-apple
requested changes
Feb 20, 2023
chirag-silabs
force-pushed
the
feature/siwx917_factory_data
branch
from
c4366bb to
d5d73a6
Compare
bzbarsky-apple
approved these changes
Feb 20, 2023
| { | ||
| for (uint8_t i = 0; i < result1.size(); i++) | ||
| { | ||
| outBuf[i] = result1.at(i); |
There was a problem hiding this comment.
The lack of a length check here is pretty fragile, but ok.
There was a problem hiding this comment.
Resolving to merge - platform owner approved this potential out of bounds access :/
There was a problem hiding this comment.
Merged, now re-opening for visibility. The method should have taken a span as input to do bounds checking.
|
PR #24747: Size comparison from e0e3225 to d5d73a6 Increases (3 builds for bl602, bl702)
Decreases (1 build for bl602)
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
|
rcasallas-silabs
approved these changes
Feb 20, 2023
|
PR #24747: Size comparison from e0e3225 to 4ca4747 Increases (4 builds for cc32xx, mbed, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Adding the temp logic for the factory device data provider for SiWx917 * Restyled by whitespace * Added some comments * restyling the PR * Added the device config for other applications * Restyled by clang-format * Addressed review comments * Setting the device config to default values and using static cast * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory data provider for SiWx917
This is a temp fix, the user can write the details in the DeviceConfig.h (Discriminator, passcode and all) and then build the project with
siwx917_commissionable_data=trueand then the device properties will be flashed in the nvm section of the SiWx917 board.