-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zap regen all golden images #24527
Zap regen all golden images #24527
Conversation
… make the diff work. Need to debug that one ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes zap_regen_all
fail for me:
stamp_file: Optional[str] = None
Unable to check version using %r. Assuming version is ok. ['node', 'src-script/zap-start.js']
^
SyntaxError: invalid syntax
...
subprocess.CalledProcessError: Command '['./scripts/tools/zap/test_generate.py', '--output', './out/test_goldenm8qxiqlu', '--regenerate']' returned non-zero exit status 1.
I think this line in that script:
#!/usr/bin/env python
should have python3
, not python
, for this to work.
In general, these scripts can't assume they are running after activate (though people may need to install some things like click and pyyaml to make them work without activate).
Updated the script. |
PR #24527: Size comparison from 99a9b7b to bae5b66 Increases (3 builds for bl702, cc13x2_26x2, qpg)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bae5b66
to
ba8b370
Compare
PR #24527: Size comparison from 8517156 to ba8b370 Increases (9 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Decreases (9 builds for bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24527: Size comparison from 4b0aefe to 0039730 Increases (4 builds for cc13x2_26x2, esp32, telink)
Decreases (12 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Regenerate golden images during zap regen all * Restyle * Ensure output is in out. For some reason using tmp directory does not make the diff work. Need to debug that one ... * Add a comment explaining why the temporary directory is in the out directory * Explain why temporary directory in out is needed * Make test_generate try to use python3 if available * Added comments on various code points based on review
Make zap_regen_all be able to update golden test images as well.
This allows running a single script on zap changes.