Zap regen all golden images #24527
Merged
Zap regen all golden images #24527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make the diff work. Need to debug that one ...
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
bzbarsky-apple
requested changes
Jan 19, 2023
There was a problem hiding this comment.
This makes zap_regen_all fail for me:
stamp_file: Optional[str] = None
Unable to check version using %r. Assuming version is ok. ['node', 'src-script/zap-start.js']
^
SyntaxError: invalid syntax
...
subprocess.CalledProcessError: Command '['./scripts/tools/zap/test_generate.py', '--output', './out/test_goldenm8qxiqlu', '--regenerate']' returned non-zero exit status 1.
I think this line in that script:
#!/usr/bin/env python
should have python3, not python, for this to work.
In general, these scripts can't assume they are running after activate (though people may need to install some things like click and pyyaml to make them work without activate).
Updated the script. |
bzbarsky-apple
approved these changes
Jan 19, 2023
|
PR #24527: Size comparison from 99a9b7b to bae5b66 Increases (3 builds for bl702, cc13x2_26x2, qpg)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
force-pushed
the
zap_regen_all_golden_images
branch
from
bae5b66
to
ba8b370
Compare
|
PR #24527: Size comparison from 8517156 to ba8b370 Increases (9 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Decreases (9 builds for bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #24527: Size comparison from 4b0aefe to 0039730 Increases (4 builds for cc13x2_26x2, esp32, telink)
Decreases (12 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Regenerate golden images during zap regen all * Restyle * Ensure output is in out. For some reason using tmp directory does not make the diff work. Need to debug that one ... * Add a comment explaining why the temporary directory is in the out directory * Explain why temporary directory in out is needed * Make test_generate try to use python3 if available * Added comments on various code points based on review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make zap_regen_all be able to update golden test images as well.
This allows running a single script on zap changes.